Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2711553002: Rename the LoginApps policy into DeviceLoginScreenAppInstallList (Closed)

Created:
3 years, 10 months ago by emaxx
Modified:
3 years, 10 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the LoginApps policy into DeviceLoginScreenAppInstallList This fixes the previously introduced policy name to be more consistent with the naming of the existing policies: the "DeviceLoginScreen" prefix is typically used for policies that operate on the Chrome OS login screen. Also this makes the new policy (and the corresponding prefs) a bit closer to their per-user analogs - ExtensionInstallForcelist et al. The renaming should be fine, as this policy is implemented currently neither on the client nor on the server side. Also this fixes the version number for the policy (as we're aiming at M58 currently), and marks it as "future", to indicate that it's not ready for being used by the customers yet. BUG=576464 TEST=existing unit and browser tests Review-Url: https://codereview.chromium.org/2711553002 Cr-Commit-Position: refs/heads/master@{#452493} Committed: https://chromium.googlesource.com/chromium/src/+/961f09b963688aed198af56e5a369e50351a88d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/settings/cros_settings_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/settings/cros_settings_names.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
emaxx
Drew, PTAL. Achuith, this is mainly FYI, but feel free to comment on the CL ...
3 years, 10 months ago (2017-02-21 22:51:40 UTC) #7
emaxx
On 2017/02/21 22:51:40, emaxx wrote: > Drew, PTAL. > > Achuith, this is mainly FYI, ...
3 years, 10 months ago (2017-02-21 22:52:40 UTC) #8
achuithb
lgtm
3 years, 10 months ago (2017-02-22 09:41:35 UTC) #13
Andrew T Wilson (Slow)
3 years, 10 months ago (2017-02-23 12:27:01 UTC) #14
Andrew T Wilson (Slow)
lgtm
3 years, 10 months ago (2017-02-23 12:27:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711553002/1
3 years, 10 months ago (2017-02-23 14:37:24 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 15:34:22 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/961f09b963688aed198af56e5a36...

Powered by Google App Engine
This is Rietveld 408576698