Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2711543003: [Payments] Unify the card number invalid string (Closed)

Created:
3 years, 10 months ago by Mathieu
Modified:
3 years, 10 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, mathp+autofillwatch_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Unify the card number invalid string BUG=695039 TEST=builds Review-Url: https://codereview.chromium.org/2711543003 Cr-Commit-Position: refs/heads/master@{#452080} Committed: https://chromium.googlesource.com/chromium/src/+/baff1b62a218ccb26e1fd06f6a192bbabc937ee1

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/autofill/core/browser/validation_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/payments_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Mathieu
PTAL
3 years, 10 months ago (2017-02-22 15:47:18 UTC) #4
please use gerrit instead
lgtm
3 years, 10 months ago (2017-02-22 16:24:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711543003/20001
3 years, 10 months ago (2017-02-22 16:27:58 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:34:05 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/baff1b62a218ccb26e1fd06f6a19...

Powered by Google App Engine
This is Rietveld 408576698