Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: Fix and add more metrics unit tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.h
diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h
index 3dfe016070afcd45b930b431a3e9d1f71596696a..be6e765961b398531b3130470c2e63feb282c841 100644
--- a/components/autofill/core/browser/personal_data_manager.h
+++ b/components/autofill/core/browser/personal_data_manager.h
@@ -232,9 +232,12 @@ class PersonalDataManager : public KeyedService,
// Gets credit cards that can suggest data for |type|. See
// GetProfileSuggestions for argument descriptions. The variant in each
// GUID pair should be ignored.
+ // Also sets isBankNameAvailable to true if bank names are available for at
+ // least one suggestion.
std::vector<Suggestion> GetCreditCardSuggestions(
const AutofillType& type,
- const base::string16& field_contents);
+ const base::string16& field_contents,
+ bool& isBankNameAvailable);
sebsg 2017/06/12 21:17:00 This is contrary to the Google C++ style guide, al
Shanfeng 2017/06/12 23:34:58 Done.
// Re-loads profiles and credit cards from the WebDatabase asynchronously.
// In the general case, this is a no-op and will re-create the same
@@ -503,10 +506,13 @@ class PersonalDataManager : public KeyedService,
// Returns credit card suggestions based on the |cards_to_suggest| and the
// |type| and |field_contents| of the credit card field.
+ // Also sets isBankNameAvailable to true if bank names are available for at
+ // least one suggestion.
std::vector<Suggestion> GetSuggestionsForCards(
const AutofillType& type,
const base::string16& field_contents,
- const std::vector<CreditCard*>& cards_to_suggest) const;
+ const std::vector<CreditCard*>& cards_to_suggest,
+ bool& isBankNameAvailable) const;
sebsg 2017/06/12 21:17:00 ditto
Shanfeng 2017/06/12 23:34:58 Done.
// Runs the Autofill use date fix routine if it's never been done. Returns
// whether the routine was run.

Powered by Google App Engine
This is Rietveld 408576698