Experiment to add bank name in autofill ui.

components/autofill/core/browser/personal_data_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
 
 #include <list>
 #include <memory>
 #include <set>
@@ skipping 214 matching lines @@
       const std::vector<ServerFieldType>& other_field_types);
 
   // Returns the credit cards to suggest to the user. Those have been deduped
   // and ordered by frecency with the expired cards put at the end of the
   // vector.
   const std::vector<CreditCard*> GetCreditCardsToSuggest() const;
 
   // Gets credit cards that can suggest data for |type|. See
   // GetProfileSuggestions for argument descriptions. The variant in each
   // GUID pair should be ignored.
+  // Also sets isBankNameAvailable to true if bank names are available for at
+  // least one suggestion.
   std::vector<Suggestion> GetCreditCardSuggestions(
       const AutofillType& type,
-      const base::string16& field_contents);
+      const base::string16& field_contents,
+      bool& isBankNameAvailable);

[sebsg, 2017/06/12 21:17:00]

This is contrary to the Google C++ style guide, all ref parameters must be
const: https://google.github.io/styleguide/cppguide.html#Reference_Arguments

[Shanfeng, 2017/06/12 23:34:58]

Done.

 
   // Re-loads profiles and credit cards from the WebDatabase asynchronously.
   // In the general case, this is a no-op and will re-create the same
   // in-memory model as existed prior to the call.  If any change occurred to
   // profiles in the WebDatabase directly, as is the case if the browser sync
   // engine processed a change from the cloud, we will learn of these as a
   // result of this call.
   //
   // Also see SetProfile for more details.
   virtual void Refresh();
@@ skipping 248 matching lines @@
       bool* imported_credit_card_matches_masked_server_credit_card);
 
   // Functionally equivalent to GetProfiles(), but also records metrics if
   // |record_metrics| is true. Metrics should be recorded when the returned
   // profiles will be used to populate the fields shown in an Autofill popup.
   virtual const std::vector<AutofillProfile*>& GetProfiles(
       bool record_metrics) const;
 
   // Returns credit card suggestions based on the |cards_to_suggest| and the
   // |type| and |field_contents| of the credit card field.
+  // Also sets isBankNameAvailable to true if bank names are available for at
+  // least one suggestion.
   std::vector<Suggestion> GetSuggestionsForCards(
       const AutofillType& type,
       const base::string16& field_contents,
-      const std::vector<CreditCard*>& cards_to_suggest) const;
+      const std::vector<CreditCard*>& cards_to_suggest,
+      bool& isBankNameAvailable) const;

[sebsg, 2017/06/12 21:17:00]

ditto

[Shanfeng, 2017/06/12 23:34:58]

Done.

 
   // Runs the Autofill use date fix routine if it's never been done. Returns
   // whether the routine was run.
   void ApplyProfileUseDatesFix();
 
   // Applies the deduping routine once per major version if the feature is
   // enabled. Calls DedupeProfiles with the content of |web_profiles_| as a
   // parameter. Removes the profiles to delete from the database and updates the
   // others. Also updates the credit cards' billing address references. Returns
   // true if the routine was run.
@@ skipping 98 matching lines @@
   // The context for the request to be used to fetch libaddressinput's address
   // validation rules.
   scoped_refptr<net::URLRequestContextGetter> context_getter_;
 
   DISALLOW_COPY_AND_ASSIGN(PersonalDataManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_