Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: Fix and add more metrics unit tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index d849ce143f8bce195815706ee4ac48778b4ad44e..9d8ea6a05ec0c03ff273c30b0d61c67ebae74259 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -542,7 +542,11 @@ class AutofillMetrics {
// submitted. If the submission is not interrupted by JavaScript, the "form
// submitted" event above will also be logged.
FORM_EVENT_SUGGESTION_SHOWN_WILL_SUBMIT_ONCE,
-
+ // A dropdown with suggestions was shown and suggestions have bank names.
+ FORM_EVENT_SUGGESTIONS_SHOWN_WITH_BANK_NAME_AVAILABLE_ONCE,
sebsg 2017/06/12 21:17:00 Since it's for an experiment, I would prefer the m
Shanfeng 2017/06/12 23:34:58 Do you mean create a new FormEvent like: enum Bank
sebsg 2017/06/13 13:36:04 yep I'd prefer that :)
+ // A server suggestion was used to fill the form and suggestions have bank
+ // names.
+ FORM_EVENT_SERVER_SUGGESTION_FILLED_WITH_BANK_NAME_AVAILABLE_ONCE,
NUM_FORM_EVENTS,
};
@@ -937,6 +941,7 @@ class AutofillMetrics {
void OnFormSubmitted();
+ void SetBankNameAvailable();
private:
void Log(FormEvent event) const;
@@ -950,6 +955,7 @@ class AutofillMetrics {
bool has_logged_suggestion_filled_;
bool has_logged_will_submit_;
bool has_logged_submitted_;
+ bool has_logged_bank_name_available_;
bool logged_suggestion_filled_was_server_data_;
bool logged_suggestion_filled_was_masked_server_card_;

Powered by Google App Engine
This is Rietveld 408576698