Experiment to add bank name in autofill ui.

components/autofill/core/browser/autofill_metrics.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 #include <utility>
@@ skipping 524 matching lines @@
     FORM_EVENT_LOCAL_SUGGESTION_WILL_SUBMIT_ONCE,
     FORM_EVENT_SERVER_SUGGESTION_WILL_SUBMIT_ONCE,
     FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_WILL_SUBMIT_ONCE,
     // A dropdown with suggestions was shown and a form was submitted after
     // that.
     FORM_EVENT_SUGGESTION_SHOWN_SUBMITTED_ONCE,
     // A dropdown with suggestions was shown and a form is about to be
     // submitted. If the submission is not interrupted by JavaScript, the "form
     // submitted" event above will also be logged.
     FORM_EVENT_SUGGESTION_SHOWN_WILL_SUBMIT_ONCE,
-
+    // A dropdown with suggestions was shown and suggestions have bank names.
+    FORM_EVENT_SUGGESTIONS_SHOWN_WITH_BANK_NAME_AVAILABLE_ONCE,

[sebsg, 2017/06/12 21:17:00]

Since it's for an experiment, I would prefer the metric to be logged on its own
please.

[Shanfeng, 2017/06/12 23:34:58]

Do you mean create a new FormEvent like:
enum BankNameFormEvent {
  FORM_EVENT_SUGGESTIONS_SHOWN_WITH_BANK_NAME_AVAILABLE_ONCE,
  FORM_EVENT_SERVER_SUGGESTION_FILLED_WITH_BANK_NAME_AVAILABLE_ONCE,
};
?

[sebsg, 2017/06/13 13:36:04]

yep I'd prefer that :)

+    // A server suggestion was used to fill the form and suggestions have bank
+    // names.
+    FORM_EVENT_SERVER_SUGGESTION_FILLED_WITH_BANK_NAME_AVAILABLE_ONCE,
     NUM_FORM_EVENTS,
   };
 
   // Events related to the Unmask Credit Card Prompt.
   enum UnmaskPromptEvent {
     // The prompt was shown.
     UNMASK_PROMPT_SHOWN = 0,
     // The prompt was closed without attempting to unmask the card.
     UNMASK_PROMPT_CLOSED_NO_ATTEMPTS,
     // The prompt was closed without unmasking the card, but with at least
@@ skipping 374 matching lines @@
     // In case of masked cards, caller must make sure this gets called before
     // the card is upgraded to a full card.
     void OnDidFillSuggestion(const CreditCard& credit_card);
 
     void OnDidFillSuggestion(const AutofillProfile& profile);
 
     void OnWillSubmitForm();
 
     void OnFormSubmitted();
 
+    void SetBankNameAvailable();
    private:
     void Log(FormEvent event) const;
 
     bool is_for_credit_card_;
     size_t server_record_type_count_;
     size_t local_record_type_count_;
     bool is_context_secure_;
     bool has_logged_interacted_;
     bool has_logged_suggestions_shown_;
     bool has_logged_masked_server_card_suggestion_selected_;
     bool has_logged_suggestion_filled_;
     bool has_logged_will_submit_;
     bool has_logged_submitted_;
+    bool has_logged_bank_name_available_;
     bool logged_suggestion_filled_was_server_data_;
     bool logged_suggestion_filled_was_masked_server_card_;
 
     // The last field that was polled for suggestions.
     FormFieldData last_polled_field_;
 
     FormInteractionsUkmLogger*
         form_interactions_ukm_logger_;  // Weak reference.
   };
 
  private:
   static const int kNumCardUploadDecisionMetrics = 12;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_