Experiment to add bank name in autofill ui.

components/autofill/core/browser/credit_card.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 494 matching lines @@
   base::string16 type = TypeForDisplay();
 
   base::string16 digits = LastFourDigits();
   if (digits.empty())
     return type;
 
   // TODO(estade): i18n?
   return type + base::string16(kMidlineEllipsis) + digits;
 }
 
+base::string16 CreditCard::BankNameAndLastFourDigits() const {
+  base::string16 digits = LastFourDigits();
+  // TODO(szhangcs) The length to show here is limited, so we are going to do a
+  // mapping from long bank names to short bank names. We will do the mapping
+  // after Bin Service verified what are the Bin ranges that have good data
+  // quality.
+  if (digits.empty())
+    return ASCIIToUTF16(bank_name_);
+  size_t bank_name_length = 8;

[sebsg, 2017/04/12 22:18:15]

You could use a min function? To get the min of the bank_name and 8?

[Shanfeng, 2017/04/13 18:29:09]

Done.

+  if (bank_name_.size() < bank_name_length) {
+    bank_name_length = bank_name_.size();
+  }
+  return ASCIIToUTF16(bank_name_.substr(0, bank_name_length)) +
+         base::string16(kMidlineEllipsis) + digits;

[sebsg, 2017/04/12 22:18:15]

So what happens if the bank name is longer? Does it just show "Bank of ...1234" 
for Bank of America?

[Shanfeng, 2017/04/13 18:29:09]

Yeah... 8 digits are too short. Verified that 15 chars can fit on Nexus5. So
changed to 15 for now. Will discuss with Mathieu and UX about what's the
appropriate number here.

+}
+
 base::string16 CreditCard::AbbreviatedExpirationDateForDisplay() const {
   base::string16 month = ExpirationMonthAsString();
   base::string16 year = Expiration2DigitYearAsString();
   return month.empty() || year.empty()
              ? base::string16()
              : l10n_util::GetStringFUTF16(
                    IDS_AUTOFILL_CREDIT_CARD_EXPIRATION_DATE_ABBR, month, year);
 }
 
 void CreditCard::operator=(const CreditCard& credit_card) {
   set_use_count(credit_card.use_count());
   set_use_date(credit_card.use_date());
   set_modification_date(credit_card.modification_date());
 
   if (this == &credit_card)
     return;
 
   record_type_ = credit_card.record_type_;
   number_ = credit_card.number_;
   name_on_card_ = credit_card.name_on_card_;
   type_ = credit_card.type_;
   expiration_month_ = credit_card.expiration_month_;
   expiration_year_ = credit_card.expiration_year_;
   server_id_ = credit_card.server_id_;
   server_status_ = credit_card.server_status_;
   billing_address_id_ = credit_card.billing_address_id_;
+  bank_name_ = credit_card.bank_name_;
 
   set_guid(credit_card.guid());
   set_origin(credit_card.origin());
 }
 
 base::string16 CreditCard::GetLastUsedDateForDisplay(
     const std::string& app_locale) const {
   bool show_expiration_date =
       ShowExpirationDateInAutofillCreditCardLastUsedDate();
 
@@ skipping 95 matching lines @@
   }
 
   int comparison = server_id_.compare(credit_card.server_id_);
   if (comparison != 0)
     return comparison;
 
   comparison = billing_address_id_.compare(credit_card.billing_address_id_);
   if (comparison != 0)
     return comparison;
 
+  comparison = bank_name_.compare(credit_card.bank_name_);
+  if (comparison != 0)
+    return comparison;
+
   if (static_cast<int>(server_status_) <
       static_cast<int>(credit_card.server_status_))
     return -1;
   if (static_cast<int>(server_status_) >
       static_cast<int>(credit_card.server_status_))
     return 1;
   if (static_cast<int>(record_type_) <
       static_cast<int>(credit_card.record_type_))
     return -1;
   if (static_cast<int>(record_type_) >
@@ skipping 263 matching lines @@
 const char kDinersCard[] = "dinersCC";
 const char kDiscoverCard[] = "discoverCC";
 const char kGenericCard[] = "genericCC";
 const char kJCBCard[] = "jcbCC";
 const char kMasterCard[] = "masterCardCC";
 const char kMirCard[] = "mirCC";
 const char kUnionPay[] = "unionPayCC";
 const char kVisaCard[] = "visaCC";
 
 }  // namespace autofill