Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: For git sync and file format Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 828 matching lines...) Expand 10 before | Expand all | Expand 10 after
839 #endif // OS_ANDROID 839 #endif // OS_ANDROID
840 840
841 #if defined(OS_ANDROID) 841 #if defined(OS_ANDROID)
842 const FeatureEntry::FeatureParam kPersistentMenuItemEnabled[] = { 842 const FeatureEntry::FeatureParam kPersistentMenuItemEnabled[] = {
843 {"persistent_menu_item_enabled", "true"}}; 843 {"persistent_menu_item_enabled", "true"}};
844 844
845 const FeatureEntry::FeatureVariation kDataReductionMainMenuFeatureVariations[] = 845 const FeatureEntry::FeatureVariation kDataReductionMainMenuFeatureVariations[] =
846 {{"(persistent)", kPersistentMenuItemEnabled, 846 {{"(persistent)", kPersistentMenuItemEnabled,
847 arraysize(kPersistentMenuItemEnabled), nullptr}}; 847 arraysize(kPersistentMenuItemEnabled), nullptr}};
848 #endif // OS_ANDROID 848 #endif // OS_ANDROID
849 const FeatureEntry::FeatureParam
850 kAutofillCreditCardBankNameFeatureVariationShowInTitle[] = {
851 {"show_bank_name_in_title", "true"}};
852
853 const FeatureEntry::FeatureVariation
854 kAutofillCreditCardBankNameFeatureVariations[] = {
855 {"Show bank name in title",
856 kAutofillCreditCardBankNameFeatureVariationShowInTitle,
857 arraysize(kAutofillCreditCardBankNameFeatureVariationShowInTitle),
858 nullptr}};
849 859
850 // RECORDING USER METRICS FOR FLAGS: 860 // RECORDING USER METRICS FOR FLAGS:
851 // ----------------------------------------------------------------------------- 861 // -----------------------------------------------------------------------------
852 // The first line of the entry is the internal name. 862 // The first line of the entry is the internal name.
853 // 863 //
854 // To add a new entry, add to the end of kFeatureEntries. There are two 864 // To add a new entry, add to the end of kFeatureEntries. There are two
855 // distinct types of entries: 865 // distinct types of entries:
856 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE 866 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
857 // macro for this type supplying the command line to the macro. 867 // macro for this type supplying the command line to the macro.
858 // . MULTI_VALUE: a list of choices, the first of which should correspond to a 868 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
(...skipping 1593 matching lines...) Expand 10 before | Expand all | Expand 10 after
2452 kOsAndroid, 2462 kOsAndroid,
2453 FEATURE_WITH_PARAMS_VALUE_TYPE( 2463 FEATURE_WITH_PARAMS_VALUE_TYPE(
2454 autofill::kAutofillCreditCardPopupLayout, 2464 autofill::kAutofillCreditCardPopupLayout,
2455 kAutofillCreditCardPopupLayoutFeatureVariations, 2465 kAutofillCreditCardPopupLayoutFeatureVariations,
2456 "AutofillCreditCardPopupLayout")}, 2466 "AutofillCreditCardPopupLayout")},
2457 {"native-android-history-manager", 2467 {"native-android-history-manager",
2458 flag_descriptions::kNativeAndroidHistoryManager, 2468 flag_descriptions::kNativeAndroidHistoryManager,
2459 flag_descriptions::kNativeAndroidHistoryManagerDescription, kOsAndroid, 2469 flag_descriptions::kNativeAndroidHistoryManagerDescription, kOsAndroid,
2460 FEATURE_VALUE_TYPE(features::kNativeAndroidHistoryManager)}, 2470 FEATURE_VALUE_TYPE(features::kNativeAndroidHistoryManager)},
2461 #endif // OS_ANDROID 2471 #endif // OS_ANDROID
2472
2462 {"enable-autofill-credit-card-last-used-date-display", 2473 {"enable-autofill-credit-card-last-used-date-display",
2463 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplay, 2474 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplay,
2464 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplayDescription, 2475 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplayDescription,
2465 kOsAll, 2476 kOsAll,
2466 FEATURE_WITH_PARAMS_VALUE_TYPE( 2477 FEATURE_WITH_PARAMS_VALUE_TYPE(
2467 autofill::kAutofillCreditCardLastUsedDateDisplay, 2478 autofill::kAutofillCreditCardLastUsedDateDisplay,
2468 kAutofillCreditCardLastUsedDateFeatureVariations, 2479 kAutofillCreditCardLastUsedDateFeatureVariations,
2469 "AutofillCreditCardLastUsedDate")}, 2480 "AutofillCreditCardLastUsedDate")},
2481
sebsg 2017/04/12 22:18:15 nit: remove new-line
Shanfeng 2017/04/13 18:29:09 Done.
2482 {"enable-autofill-credit-card-bank-name-display",
2483 flag_descriptions::kEnableAutofillCreditCardBankNameDisplay,
2484 flag_descriptions::kEnableAutofillCreditCardBankNameDisplayDescription,
2485 kOsAll, FEATURE_VALUE_TYPE(autofill::kAutofillCreditCardBankNameDisplay)},
2486
2470 #if defined(OS_WIN) 2487 #if defined(OS_WIN)
2471 {"windows10-custom-titlebar", 2488 {"windows10-custom-titlebar",
2472 flag_descriptions::kWindows10CustomTitlebarName, 2489 flag_descriptions::kWindows10CustomTitlebarName,
2473 flag_descriptions::kWindows10CustomTitlebarDescription, kOsWin, 2490 flag_descriptions::kWindows10CustomTitlebarDescription, kOsWin,
2474 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)}, 2491 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)},
2475 #endif // OS_WIN 2492 #endif // OS_WIN
2476 2493
2477 #if defined(OS_ANDROID) 2494 #if defined(OS_ANDROID)
2478 {"lsd-permission-prompt", flag_descriptions::kLsdPermissionPromptName, 2495 {"lsd-permission-prompt", flag_descriptions::kLsdPermissionPromptName,
2479 flag_descriptions::kLsdPermissionPromptDescription, kOsAndroid, 2496 flag_descriptions::kLsdPermissionPromptDescription, kOsAndroid,
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
2851 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2868 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2852 2869
2853 const FeatureEntry* GetFeatureEntries(size_t* count) { 2870 const FeatureEntry* GetFeatureEntries(size_t* count) {
2854 *count = arraysize(kFeatureEntries); 2871 *count = arraysize(kFeatureEntries);
2855 return kFeatureEntries; 2872 return kFeatureEntries;
2856 } 2873 }
2857 2874
2858 } // namespace testing 2875 } // namespace testing
2859 2876
2860 } // namespace about_flags 2877 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | components/autofill/core/browser/credit_card.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698