[ios] Simplifies the Find In Page JS unittest.

[ios] Simplifies the Find In Page JS unittest.

This test does not need a full FindInPageController, so that is removed from the
test fixture.  Additionally, the find in page unittest files are moved from
ios/chrome/browser/web to ios/chrome/browser/find_in_page.

BUG=691073
Review-Url: https://codereview.chromium.org/2711513002
Cr-Commit-Position: refs/heads/master@{#453241}
Committed: https://chromium.googlesource.com/chromium/src/+/e6c32ed57fd0f31d1f197e239e17c7b5780f47fc

[rohitrao (ping after 24h), 2017-02-21 15:52:21]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-02-21 15:53:13]

rohitrao@chromium.org changed reviewers:
+ justincohen@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:30:01]

Dry run: This issue passed the CQ dry run.

[justincohen, 2017-02-22 03:20:29]

https://codereview.chromium.org/2711513002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/find_in_page_js_unittest.mm (right):

https://codereview.chromium.org/2711513002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/find_in_page_js_unittest.mm:73:
[findInPageJsManager_ setWidth:frame.size.width height:frame.size.height];
Is it weird that we call init via setWidth:height: ?

[rohitrao (ping after 24h), 2017-02-24 20:39:15]

https://codereview.chromium.org/2711513002/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/find_in_page_js_unittest.mm (right):

https://codereview.chromium.org/2711513002/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/find_in_page_js_unittest.mm:73:
[findInPageJsManager_ setWidth:frame.size.width height:frame.size.height];
On 2017/02/22 03:20:29, justincohen (OOO until Mar 20) wrote:
> Is it weird that we call init via setWidth:height: ?

A bit, yes.  I don't really have a better suggestion at this point.

[justincohen, 2017-02-27 14:40:41]

sadly LGTM

[rohitrao (ping after 24h), 2017-02-27 16:02:56]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-02-27 16:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2711513002/#ps20001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-02-27 16:03:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:16:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488211376834320,
"parent_rev": "3dc27d31ac4b1454c0c75cec4d01f6d0b9ff2be6", "commit_rev":
"e6c32ed57fd0f31d1f197e239e17c7b5780f47fc"}

[commit-bot: I haz the power, 2017-02-27 17:16:58]

Description was changed from

==========
[ios] Simplifies the Find In Page JS unittest.

This test does not need a full FindInPageController, so that is removed from the
test fixture.  Additionally, the find in page unittest files are moved from
ios/chrome/browser/web to ios/chrome/browser/find_in_page.

BUG=691073
==========

to

==========
[ios] Simplifies the Find In Page JS unittest.

This test does not need a full FindInPageController, so that is removed from the
test fixture.  Additionally, the find in page unittest files are moved from
ios/chrome/browser/web to ios/chrome/browser/find_in_page.

BUG=691073

Review-Url: https://codereview.chromium.org/2711513002
Cr-Commit-Position: refs/heads/master@{#453241}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6c32ed57fd0f31d1f197e239e17...
==========

[commit-bot: I haz the power, 2017-02-27 17:17:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e6c32ed57fd0f31d1f197e239e17...