Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2711423002: Fix for serializing cascades with not-assignment access to properties. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for serializing cascades with not-assignment access to properties. This was triggering a small avalanche of inference failures internally. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/123c8a96687c52647f47c1b0efff5d21a7aba83b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-02-24 20:45:36 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-24 20:53:36 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 123c8a96687c52647f47c1b0efff5d21a7aba83b (presubmit successful).
3 years, 10 months ago (2017-02-24 20:59:54 UTC) #4
Paul Berry
3 years, 10 months ago (2017-02-24 22:49:06 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698