Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

Issue 2711423002: Fix for serializing cascades with not-assignment access to properties. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/summarize_const_expr.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
index fc3184bf0cc53e0dbab1eb7e7048cdd932793503..dcde920733b39fa7586c3118341441b29325bca8 100644
--- a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
@@ -632,7 +632,9 @@ abstract class AbstractConstExprSerializer {
references.add(ref);
operations.add(UnlinkedExprOperation.pushReference);
} else {
- _serialize(expr.target);
+ if (!expr.isCascaded) {
+ _serialize(expr.target);
+ }
strings.add(expr.propertyName.name);
operations.add(UnlinkedExprOperation.extractProperty);
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698