Chromium Code Reviews
DescriptionRevert of CSP: 'self' should work inside sandboxes. (patchset #2 id:20001 of https://codereview.chromium.org/2699663002/ )
Reason for revert:
I suspect that this breaks Synology's UI, which submits a form through
an `about:blank` frame. Perhaps we're not persisting the fallback base
URL correctly?
BUG=695058
Original issue's description:
> CSP: 'self' should work inside sandboxes.
>
> We ought to be looking at the URL of a sandboxed resource when resolving
> the CSP source expression 'self'. Currently, we're looking at the origin
> of the resource, which is generally correct, but fails if the resource
> has been pushed into an opaque origin.
>
> This patch uses the fallback base URL of a document rather than its
> origin to do the comparison.
>
> BUG=692475
> R=jochen@chromium.org
> CC=andypaicu@chromium.org
>
> Review-Url: https://codereview.chromium.org/2699663002
> Cr-Commit-Position: refs/heads/master@{#451626}
> Committed: https://chromium.googlesource.com/chromium/src/+/9d3329c4a3d3dd0ab85869b7de4d62a8e2797520
TBR=jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=692475
Review-Url: https://codereview.chromium.org/2711363004
Cr-Commit-Position: refs/heads/master@{#453091}
Committed: https://chromium.googlesource.com/chromium/src/+/3a1bb4d2c8bd64fdf57558d2ff39a5f356597af4
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||