Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2711353002: [LoadIC] Use LoadIC_Uninitialized for 0->PRE transitions (Closed)

Created:
3 years, 10 months ago by Jakob Kummerow
Modified:
3 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[LoadIC] Use LoadIC_Uninitialized for 0->PRE transitions Avoiding runtime call overhead. There's a fast path for Function.prototype loads, which are very common. BUG=v8:5269 Review-Url: https://codereview.chromium.org/2711353002 Cr-Commit-Position: refs/heads/master@{#43474} Committed: https://chromium.googlesource.com/v8/v8/+/2585ee06efb1b3051903451272959d083397295a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -6 lines) Patch
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-ic.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/accessor-assembler.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/ic/accessor-assembler.cc View 6 chunks +86 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jakob Kummerow
PTAL.
3 years, 10 months ago (2017-02-24 11:56:32 UTC) #2
Igor Sheludko
lgtm
3 years, 9 months ago (2017-02-27 09:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711353002/1
3 years, 9 months ago (2017-02-28 10:35:13 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 11:04:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2585ee06efb1b3051903451272959d08339...

Powered by Google App Engine
This is Rietveld 408576698