Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2711343003: [tab_container] Remove tab_strip container (Closed)

Created:
3 years, 10 months ago by edchin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, marq+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[tab_container] Remove tab_strip container BUG= Review-Url: https://codereview.chromium.org/2711343003 Cr-Commit-Position: refs/heads/master@{#460385} Committed: https://chromium.googlesource.com/chromium/src/+/7f0cbdafc2ad14f10f0885ed85759d68cc5cde19

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -568 lines) Patch
M ios/clean/chrome/browser/ui/tab/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D ios/clean/chrome/browser/ui/tab_strip/BUILD.gn View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_coordinator.h View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_coordinator.mm View 1 2 1 chunk +0 lines, -101 lines 0 comments Download
D ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_view_controller.h View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_view_controller.mm View 1 2 1 chunk +0 lines, -277 lines 0 comments Download
M ios/showcase/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/showcase/core/showcase_model.mm View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D ios/showcase/tab_strip/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D ios/showcase/tab_strip/sc_tab_strip_coordinator.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
D ios/showcase/tab_strip/sc_tab_strip_coordinator.mm View 1 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 34 (25 generated)
edchin
3 years, 10 months ago (2017-02-24 15:59:31 UTC) #11
marq (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-02 05:50:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711343003/20001
3 years, 9 months ago (2017-03-02 06:09:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/52453)
3 years, 9 months ago (2017-03-02 06:18:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711343003/20001
3 years, 9 months ago (2017-03-02 07:18:23 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/165341)
3 years, 9 months ago (2017-03-02 07:26:07 UTC) #20
marq (ping after 24h)
Please get this landed, so we aren't keeping dead code around.
3 years, 8 months ago (2017-03-28 12:16:15 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711343003/80001
3 years, 8 months ago (2017-03-29 14:48:41 UTC) #31
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 14:54:37 UTC) #34
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7f0cbdafc2ad14f10f0885ed8575...

Powered by Google App Engine
This is Rietveld 408576698