Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 271133002: Revert 268794 "Lock Rotation when screen is manually rotated" (Closed)

Created:
6 years, 7 months ago by flackr
Modified:
6 years, 7 months ago
Reviewers:
jonross
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 268794 "Lock Rotation when screen is manually rotated" Introduced http://crbug.com/371426. > Lock Rotation when screen is manually rotated > > Lock rotation if a user has rotated the display upon entering maximize mode. > Only reset the display rotation upon exiting maximize mode, if rotation lock > has not been established. > > TEST=MaximizeModeControllerTest > BUG=369505 > > Review URL: https://codereview.chromium.org/261163004 R=jonross@chromium.org TBR=jonross@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -58 lines) Patch
M trunk/src/ash/wm/maximize_mode/maximize_mode_controller.h View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/ash/wm/maximize_mode/maximize_mode_controller.cc View 3 chunks +24 lines, -30 lines 0 comments Download
M trunk/src/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 5 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
flackr
6 years, 7 months ago (2014-05-09 13:20:55 UTC) #1
jonross
On 2014/05/09 13:20:55, flackr wrote: LGTM
6 years, 7 months ago (2014-05-09 13:24:29 UTC) #2
flackr
6 years, 7 months ago (2014-05-09 13:48:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r269266.

Powered by Google App Engine
This is Rietveld 408576698