Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2711293003: Media Session: add test for crash with command send on iframe during unload. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Session: add test for crash with command send on iframe during unload. This is adding a test for the crash that was fixed on trunk. The test represents the minimal test case that we have been able to find. BUG=695398 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2711293003 Cr-Commit-Position: refs/heads/master@{#452806} Committed: https://chromium.googlesource.com/chromium/src/+/16e2688ef7b85f68799f5f1e1b5ed557f19c746b

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A content/browser/media/session/media_session_service_impl_browsertest.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/media/session/embed-unload.html View 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/media/session/embedder.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mlamouri (slow - plz ping)
Uploaded with the correct account this time. PTAL :)
3 years, 10 months ago (2017-02-24 11:17:42 UTC) #1
Zhiqiang Zhang (Slow)
lgtm Maybe you want to update CL description? Also it's a browser test not a ...
3 years, 10 months ago (2017-02-24 11:33:36 UTC) #4
mlamouri (slow - plz ping)
I've update the CL description and also added a comment in the test to make ...
3 years, 10 months ago (2017-02-24 12:05:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711293003/20001
3 years, 10 months ago (2017-02-24 12:06:23 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 13:23:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16e2688ef7b85f68799f5f1e1b5e...

Powered by Google App Engine
This is Rietveld 408576698