Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2711283002: Unit test for allowing popups. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unit test for allowing popups. Tests that allowing blocked popup calls |show_popup_handler| and allows future popups for the source url. BUG=None Review-Url: https://codereview.chromium.org/2711283002 Cr-Commit-Position: refs/heads/master@{#452842} Committed: https://chromium.googlesource.com/chromium/src/+/8b31d61c16a9cb2ccd668db45f63858df6899550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M ios/chrome/browser/web/blocked_popup_tab_helper_unittest.mm View 4 chunks +36 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
I'm going to fold BlockedPopupInfo into BlockedPopupTabHelper, hence the test. PTAL
3 years, 10 months ago (2017-02-23 23:51:42 UTC) #4
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-24 13:44:16 UTC) #7
Eugene But (OOO till 7-30)
Thanks for quick review!
3 years, 10 months ago (2017-02-24 16:09:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711283002/1
3 years, 10 months ago (2017-02-24 16:09:57 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 16:24:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b31d61c16a9cb2ccd668db45f63...

Powered by Google App Engine
This is Rietveld 408576698