Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2711263005: Correct some details in the instructions for modifying TTS engine. (Closed)

Created:
3 years, 10 months ago by Wez
Modified:
3 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct some details in the instructions for modifying TTS engine. BUG=616636 NOTRY=true Review-Url: https://codereview.chromium.org/2711263005 Cr-Commit-Position: refs/heads/master@{#453043} Committed: https://chromium.googlesource.com/chromium/src/+/0334393935b3a305019a982b4c33e3f51bac45f3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M docs/accessibility/patts.md View 1 chunk +11 lines, -5 lines 2 comments Download

Messages

Total messages: 10 (5 generated)
Wez
3 years, 10 months ago (2017-02-25 01:16:10 UTC) #2
dmazzoni
lgtm Thanks for the fix! Adding NOTRY=true to quickly land https://codereview.chromium.org/2711263005/diff/1/docs/accessibility/patts.md File docs/accessibility/patts.md (right): https://codereview.chromium.org/2711263005/diff/1/docs/accessibility/patts.md#newcode36 ...
3 years, 10 months ago (2017-02-25 01:56:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711263005/1
3 years, 10 months ago (2017-02-25 01:56:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0334393935b3a305019a982b4c33e3f51bac45f3
3 years, 10 months ago (2017-02-25 02:02:46 UTC) #9
Wez
3 years, 10 months ago (2017-02-25 02:06:52 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2711263005/diff/1/docs/accessibility/patts.md
File docs/accessibility/patts.md (right):

https://codereview.chromium.org/2711263005/diff/1/docs/accessibility/patts.md...
docs/accessibility/patts.md:36: cros_workon --board=$BOARD start
chromiumos-assets
On 2017/02/25 01:56:18, dmazzoni wrote:
> Is it possible the difference has to do with whether you have the
> internal or external sources checked out? Or did this change recently
> maybe?
> 
> I'm not disputing this worked for you, I'm just trying to better
> understand it...
> 

That's a good question; I did indeed just follow the public instructions, so
quite possibly.

Powered by Google App Engine
This is Rietveld 408576698