Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2711263004: Getting rid of immediate ack in DelegatedFrameHost (Relanding) (Closed)

Created:
3 years, 10 months ago by Saman Sami
Modified:
3 years, 10 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Getting rid of immediate ack in DelegatedFrameHost (Relanding) This is a relanding of https://codereview.chromium.org/2710263002/ with a fix. The original CL was causing flakes with CaptureScreenshotTest.CaptureScreenshotArea. Apparently taking screenshots depends on latency infos and latency infos somehow get lost when the frame size is wrong. BUG=692880 Review-Url: https://codereview.chromium.org/2711263004 Cr-Commit-Position: refs/heads/master@{#452924} Committed: https://chromium.googlesource.com/chromium/src/+/7f5ee4fc924e13877c064c4b73388cdffff76ecd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M content/browser/renderer_host/delegated_frame_host.cc View 4 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Saman Sami
fsamuel@: PTAL
3 years, 10 months ago (2017-02-24 20:11:00 UTC) #5
Fady Samuel
LGTM. I guess we can figure out what is going on with LatencyInfo afterward.
3 years, 10 months ago (2017-02-24 20:14:12 UTC) #6
Saman Sami
On 2017/02/24 20:14:12, Fady Samuel wrote: > LGTM. I guess we can figure out what ...
3 years, 10 months ago (2017-02-24 20:16:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711263004/1
3 years, 10 months ago (2017-02-24 20:29:54 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 21:23:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f5ee4fc924e13877c064c4b7338...

Powered by Google App Engine
This is Rietveld 408576698