Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2711263002: Revert of [ios] Creates ToolsMenuModel Class (Closed)

Created:
3 years, 10 months ago by sczs
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Creates ToolsMenuModel Class (patchset #4 id:60001 of https://codereview.chromium.org/2706293008/ ) Reason for revert: Broke EG test Original issue's description: > [ios] Creates ToolsMenuModel Class > Extracts the Model related code from ToolsMenuViewController to a new > class named ToolsMenuModel. > > This CL is just the first step on refactoring and decoupling the Model > logic, so it can be used by the new ToolsMenuVC and the old one. > > BUG=682880 > > Review-Url: https://codereview.chromium.org/2706293008 > Cr-Commit-Position: refs/heads/master@{#452585} > Committed: https://chromium.googlesource.com/chromium/src/+/8a9ed5b3b71d3915fb734b99a5e6e0db550d79db TBR=marq@chromium.org,edchin@chromium.org,lpromero@chromium.org,rohitrao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682880 Review-Url: https://codereview.chromium.org/2711263002 Cr-Commit-Position: refs/heads/master@{#452670} Committed: https://chromium.googlesource.com/chromium/src/+/8ef4aa62f40aa8ef1ab4d6841102f8bf1d931bf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -219 lines) Patch
M ios/chrome/browser/ui/tools_menu/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/chrome/browser/ui/tools_menu/tools_menu_model.h View 1 chunk +0 lines, -83 lines 0 comments Download
D ios/chrome/browser/ui/tools_menu/tools_menu_model.mm View 1 chunk +0 lines, -119 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 11 chunks +170 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sczs
Created Revert of [ios] Creates ToolsMenuModel Class
3 years, 10 months ago (2017-02-23 23:13:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711263002/1
3 years, 10 months ago (2017-02-23 23:14:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-23 23:14:13 UTC) #5
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-02-23 23:15:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711263002/1
3 years, 10 months ago (2017-02-23 23:16:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 23:22:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ef4aa62f40aa8ef1ab4d6841102...

Powered by Google App Engine
This is Rietveld 408576698