Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2711163003: Revert of Add security checks to scheduled actions (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
haraken, dcheng, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add security checks to scheduled actions (patchset #8 id:140001 of https://codereview.chromium.org/2702213004/ ) Reason for revert: Doesn't take microtasks into account - will reland with fix Original issue's description: > Add security checks to scheduled actions > > Scheduled actions end up generating code from strings, so we should put > similar restrictions as for eval() in place > > R=haraken@chromium.org,dcheng@chromium.org > BUG=693695, 694446 > > Review-Url: https://codereview.chromium.org/2702213004 > Cr-Commit-Position: refs/heads/master@{#452016} > Committed: https://chromium.googlesource.com/chromium/src/+/0ac9c3a4fbf57ad4cc2f954fc452fa62a729e0e1 TBR=dcheng@chromium.org,haraken@chromium.org,yukishiino@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=693695, 694446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -37 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jochen (gone - plz use gerrit)
Created Revert of Add security checks to scheduled actions
3 years, 10 months ago (2017-02-23 18:22:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711163003/1
3 years, 10 months ago (2017-02-23 18:23:19 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/158993) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-23 18:27:04 UTC) #5
haraken
3 years, 10 months ago (2017-02-23 21:28:16 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698