Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2711153004: predictors: Add an about:flags flag for speculative prefetch. (Closed)

Created:
3 years, 10 months ago by Benoit L
Modified:
3 years, 9 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Add an about:flags flag for speculative prefetch. BUG=631966 Review-Url: https://codereview.chromium.org/2711153004 Cr-Commit-Position: refs/heads/master@{#455817} Committed: https://chromium.googlesource.com/chromium/src/+/a26deb2c7737b2a06fd7c6b3336cca3d4f0bd76b

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
Benoit L
3 years, 9 months ago (2017-03-06 14:38:00 UTC) #6
droger
lgtm
3 years, 9 months ago (2017-03-07 14:01:44 UTC) #7
Benoit L
3 years, 9 months ago (2017-03-07 15:06:14 UTC) #9
Ilya Sherman
histograms.xml lgtm
3 years, 9 months ago (2017-03-08 01:38:51 UTC) #14
Ilya Sherman
histograms.xml lgtm
3 years, 9 months ago (2017-03-08 01:39:07 UTC) #15
srahim1
https://codereview.chromium.org/2711153004/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2711153004/diff/40001/chrome/app/generated_resources.grd#newcode4988 chrome/app/generated_resources.grd:4988: + "Speculative Prefetch" fetches likley resources early to improve ...
3 years, 9 months ago (2017-03-08 06:35:17 UTC) #17
Benoit L
On 2017/03/08 06:35:17, srahim1 wrote: > https://codereview.chromium.org/2711153004/diff/40001/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/2711153004/diff/40001/chrome/app/generated_resources.grd#newcode4988 > ...
3 years, 9 months ago (2017-03-08 15:00:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711153004/60001
3 years, 9 months ago (2017-03-08 16:26:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/336223)
3 years, 9 months ago (2017-03-08 17:26:11 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711153004/60001
3 years, 9 months ago (2017-03-09 17:21:08 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:57:28 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a26deb2c7737b2a06fd7c6b3336c...

Powered by Google App Engine
This is Rietveld 408576698