Makes canceling 'bookmark all tabs' delete the folder. Or rather,...

Makes canceling 'bookmark all tabs' delete the folder. Or rather,
makes it so that bookmark all tabs only creates the folder if the user
presses ok. I wasn't happy adding another random arg to
BookmarkEditor::Show, so I added in a structure an enum. This makes it
clearer what Show should do.

I also fixed the following:
. On gtk we wouldn't always pick the right parent for nodes.
. The context menu item is now enabled on views/gtk.

And this now breaks the mac side. I'll straighten that out right after
landing this.

BUG=24367
TEST=Make sure 'bookmark all tabs' works, as well as the bookmark
editor work. (get to the bookmark editor by creating a new bookmark,
then clicking edit, or right clicking a bookmark on the bookmark bar and
choosing edit).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29343

[Elliot Glaysher, 2009-10-16 01:07:23]

LGTM, but I also want Evan to weigh in on this, since he was the last person to
touch the gtk code.

[Evan Stade, 2009-10-16 20:08:05]

gtk bits lgtm with nits

also note the lint error

http://codereview.chromium.org/271115/diff/6001/6010
File chrome/browser/gtk/bookmark_editor_gtk.cc (right):

http://codereview.chromium.org/271115/diff/6001/6010#newcode394
Line 394: gtk_widget_modify_base(dialog->name_entry_, GTK_STATE_NORMAL,
&kErrorColor);
80

http://codereview.chromium.org/271115/diff/6001/6010#newcode402
Line 402: gtk_widget_modify_base(dialog->url_entry_, GTK_STATE_NORMAL,
&kErrorColor);
80

[sky, 2009-10-16 20:15:31]

Thanks. The lint error is error, pair is in utility.

  -Scott

On Fri, Oct 16, 2009 at 1:08 PM,  <estade@chromium.org> wrote:
>
> gtk bits lgtm with nits
>
> also note the lint error
>
>
> http://codereview.chromium.org/271115/diff/6001/6010
> File chrome/browser/gtk/bookmark_editor_gtk.cc (right):
>
> http://codereview.chromium.org/271115/diff/6001/6010#newcode394
> Line 394: gtk_widget_modify_base(dialog->name_entry_, GTK_STATE_NORMAL,
> &kErrorColor);
> 80
>
> http://codereview.chromium.org/271115/diff/6001/6010#newcode402
> Line 402: gtk_widget_modify_base(dialog->url_entry_, GTK_STATE_NORMAL,
> &kErrorColor);
> 80
>
> http://codereview.chromium.org/271115
>