Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4224)

Unified Diff: chrome/browser/browser.cc

Issue 271115: Makes canceling 'bookmark all tabs' delete the folder. Or rather,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 29276)
+++ chrome/browser/browser.cc (working copy)
@@ -1654,13 +1654,17 @@
}
void Browser::BookmarkAllTabs() {
- const BookmarkNode* node = bookmark_utils::CreateBookmarkForAllTabs(this);
- if (!node)
- return;
+ BookmarkModel* model = profile()->GetBookmarkModel();
+ DCHECK(model && model->IsLoaded());
+ BookmarkEditor::EditDetails details;
+ details.type = BookmarkEditor::EditDetails::NEW_FOLDER;
+ bookmark_utils::GetURLsForOpenTabs(this, &(details.urls));
+ DCHECK(!details.urls.empty());
+
BookmarkEditor::Show(window()->GetNativeHandle(), profile_,
- node->GetParent(), node, BookmarkEditor::SHOW_TREE,
- NULL);
+ model->GetParentForNewNodes(), details,
+ BookmarkEditor::SHOW_TREE, NULL);
}
///////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698