Removes ignition specific benchmarks.

Removes ignition specific benchmarks.

Removes the following benchmarks: 
* speedometer-ignition 
* v8.browse_desktop_ignition 
* v8.browse_mobile_ignition, 
* v8.infiniter_scroll-ignition_tbmv2 
* v8.todoMVC-ignition 

The ignition-staging configuration of v8 used in these benchmarks is no longer the 
shipping configuration. The corresponding turbo benchmarks are tracking the future 
shipping configuration of v8.

BUG=chromium:670087
This issue was moved to gerrit and landed here: https://chromium-review.googlesource.com/c/451657/.

[mythria, 2017-02-23 14:40:07]

Description was changed from

==========
Removing ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, v8.infiniterScroll, v8.TodoMVC-ignition benchmarks.
The ignition-staging configuration in these benchmarks is
no longer the shipping configuration. The corresponding turbo
benchmarks are tracking the next shipping configuration of v8.

BUG=chromium:670087
==========

to

==========
Removing ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, v8.infiniter_scroll-ignition, v8.todoMVC-ignition
benchmarks.
The ignition-staging configuration in these benchmarks is
no longer the shipping configuration. The corresponding turbo
benchmarks are tracking the next shipping configuration of v8.

BUG=chromium:670087
==========

[mythria, 2017-02-23 14:40:36]

Description was changed from

==========
Removing ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, v8.infiniter_scroll-ignition, v8.todoMVC-ignition
benchmarks.
The ignition-staging configuration in these benchmarks is
no longer the shipping configuration. The corresponding turbo
benchmarks are tracking the next shipping configuration of v8.

BUG=chromium:670087
==========

to

==========
Removing ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, v8.infiniter_scroll-ignition_tbmv2,
v8.todoMVC-ignition benchmarks.
The ignition-staging configuration in these benchmarks is
no longer the shipping configuration. The corresponding turbo
benchmarks are tracking the next shipping configuration of v8.

BUG=chromium:670087
==========

[mythria, 2017-02-23 14:42:08]

Description was changed from

==========
Removing ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, v8.infiniter_scroll-ignition_tbmv2,
v8.todoMVC-ignition benchmarks.
The ignition-staging configuration in these benchmarks is
no longer the shipping configuration. The corresponding turbo
benchmarks are tracking the next shipping configuration of v8.

BUG=chromium:670087
==========

to

==========
Removing ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, 
v8.infiniter_scroll-ignition_tbmv2, v8.todoMVC-ignition benchmarks. The
ignition-staging configuration
of v8 used in these benchmarks is no longer the shipping configuration. The
corresponding turbo
benchmarks are
tracking the next shipping configuration of v8.

BUG=chromium:670087
==========

[mythria, 2017-02-23 14:43:30]

Description was changed from

==========
Removing ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, 
v8.infiniter_scroll-ignition_tbmv2, v8.todoMVC-ignition benchmarks. The
ignition-staging configuration
of v8 used in these benchmarks is no longer the shipping configuration. The
corresponding turbo
benchmarks are
tracking the next shipping configuration of v8.

BUG=chromium:670087
==========

to

==========
Removes ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, 
v8.infiniter_scroll-ignition_tbmv2, v8.todoMVC-ignition benchmarks. 
The ignition-staging configuration of v8 used in these benchmarks is no longer
the shipping
configuration. The corresponding turbo benchmarks are tracking the future
shipping
configuration of v8.

BUG=chromium:670087
==========

[mythria, 2017-02-23 14:44:00]

Description was changed from

==========
Removes ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, 
v8.infiniter_scroll-ignition_tbmv2, v8.todoMVC-ignition benchmarks. 
The ignition-staging configuration of v8 used in these benchmarks is no longer
the shipping
configuration. The corresponding turbo benchmarks are tracking the future
shipping
configuration of v8.

BUG=chromium:670087
==========

to

==========
Removes ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, 
v8.infiniter_scroll-ignition_tbmv2, v8.todoMVC-ignition benchmarks. 
The ignition-staging configuration of v8 used in these benchmarks is no longer
the 
shipping configuration. The corresponding turbo benchmarks are tracking the
future 
shipping configuration of v8.

BUG=chromium:670087
==========

[mythria, 2017-02-23 14:44:12]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 14:44:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mythria, 2017-02-23 14:46:00]

mythria@chromium.org changed reviewers:
+ nednguyen@google.com, rmcilroy@chromium.org, ulan@chromium.org

[mythria, 2017-02-23 14:46:01]

Please take a look. This removes ignition specific benchmarks, since we no
longer need to track ignition-staging configuration. There are turbo variants
for all of these benchmarks.

Thanks,
Mythri.

[nednguyen, 2017-02-23 14:50:11]

Description was changed from

==========
Removes ignition specific benchmarks.

Removes speedometer-ignition, v8.browse_desktop_ignition,
v8.browse_mobile_ignition, 
v8.infiniter_scroll-ignition_tbmv2, v8.todoMVC-ignition benchmarks. 
The ignition-staging configuration of v8 used in these benchmarks is no longer
the 
shipping configuration. The corresponding turbo benchmarks are tracking the
future 
shipping configuration of v8.

BUG=chromium:670087
==========

to

==========
Removes ignition specific benchmarks.

Removes the following benchmarks: 
* speedometer-ignition 
* v8.browse_desktop_ignition 
* v8.browse_mobile_ignition, 
* v8.infiniter_scroll-ignition_tbmv2 
* v8.todoMVC-ignition 

The ignition-staging configuration of v8 used in these benchmarks is no longer
the 
shipping configuration. The corresponding turbo benchmarks are tracking the
future 
shipping configuration of v8.

BUG=chromium:670087
==========

[nednguyen, 2017-02-23 14:50:59]

On 2017/02/23 14:46:01, mythria wrote:
> Please take a look. This removes ignition specific benchmarks, since we no
> longer need to track ignition-staging configuration. There are turbo variants
> for all of these benchmarks.
> 
> Thanks,
> Mythri.

LGTM

THanks for clean up the benchmarks! I tweak the description a bit to make it
clearer which benchmarks we are removing. I will also update
go/chrome-benchmarks once this is landed.

[nednguyen, 2017-02-23 14:58:15]

On 2017/02/23 14:50:59, nednguyen wrote:
> On 2017/02/23 14:46:01, mythria wrote:
> > Please take a look. This removes ignition specific benchmarks, since we no
> > longer need to track ignition-staging configuration. There are turbo
variants
> > for all of these benchmarks.
> > 
> > Thanks,
> > Mythri.
> 
> LGTM
> 
> THanks for clean up the benchmarks! I tweak the description a bit to make it
> clearer which benchmarks we are removing. I will also update
> go/chrome-benchmarks once this is landed.

Ooops, I forgot that you need to run tools/perf/generate_perf_json.py to update
the benchmarks JSON config.

I will be working on adding PRESUBMIT
(https://bugs.chromium.org/p/chromium/issues/detail?id=695162) to make sure that
we don't slip this through.

[rmcilroy, 2017-02-23 15:37:49]

LGTM once Ned's happy. Thanks!

https://codereview.chromium.org/2711143002/diff/20001/tools/perf/benchmarks/v...
File tools/perf/benchmarks/v8_helper.py (left):

https://codereview.chromium.org/2711143002/diff/20001/tools/perf/benchmarks/v...
tools/perf/benchmarks/v8_helper.py:14: AppendJSFlags(options, '--turbo')
While you are here could you switch this to --future (maybe in a different CL).

[ulan, 2017-02-24 10:43:03]

lgtm!

[chromium-reviews, 2017-02-24 10:59:05]

Hi Ned,

I ran the tools/perf/generate_perf_json.py to update the config files. It
updates several lines in the chromium.perf.json file (~10000 lines patch),
chromium.perf.fyi.json (~2000 lines patch). Is this expected? I cannot
upload the patch for the chromium.perf.json file.
Please find the diff for both these files attached with this mail.  If you
think these changes are Ok, I will land it with git cl land.

Thanks,
Mythri


On Fri, Feb 24, 2017 at 10:43 AM, <ulan@chromium.org> wrote:

> lgtm!
>
> https://codereview.chromium.org/2711143002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nednguyen, 2017-02-24 12:08:05]

nednguyen@google.com changed reviewers:
+ martiniss@chromium.org

[nednguyen, 2017-02-24 12:08:58]

On 2017/02/24 10:59:05, chromium-reviews wrote:
> Hi Ned,
> 
> I ran the tools/perf/generate_perf_json.py to update the config files. It
> updates several lines in the chromium.perf.json file (~10000 lines patch),
> chromium.perf.fyi.json (~2000 lines patch). Is this expected? I cannot
> upload the patch for the chromium.perf.json file.
> Please find the diff for both these files attached with this mail.  If you
> think these changes are Ok, I will land it with git cl land.
> 
> Thanks,
> Mythri
> 
> 
> On Fri, Feb 24, 2017 at 10:43 AM, <mailto:ulan@chromium.org> wrote:
> 
> > lgtm!
> >
> > https://codereview.chromium.org/2711143002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

+Stephen: do you know why this seems to reshuffle the bots? Is this intentional
in the generate_perf_json to rebalance the machines?

[mythria, 2017-03-07 09:41:05]

On 2017/02/24 12:08:58, nednguyen wrote:
> On 2017/02/24 10:59:05, chromium-reviews wrote:
> > Hi Ned,
> > 
> > I ran the tools/perf/generate_perf_json.py to update the config files. It
> > updates several lines in the chromium.perf.json file (~10000 lines patch),
> > chromium.perf.fyi.json (~2000 lines patch). Is this expected? I cannot
> > upload the patch for the chromium.perf.json file.
> > Please find the diff for both these files attached with this mail.  If you
> > think these changes are Ok, I will land it with git cl land.
> > 
> > Thanks,
> > Mythri
> > 
> > 
> > On Fri, Feb 24, 2017 at 10:43 AM, <mailto:ulan@chromium.org> wrote:
> > 
> > > lgtm!
> > >
> > > https://codereview.chromium.org/2711143002/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> +Stephen: do you know why this seems to reshuffle the bots? Is this
intentional
> in the generate_perf_json to rebalance the machines?

Stephen, do you think the generated chromium.perf.json file is Ok? Please see
Ned's
question above.

[martiniss, 2017-03-08 00:11:53]

lgtm

[martiniss, 2017-03-08 00:12:28]

Sorry for the late review. Kept on meaning to get to this. 

Directly landing should be fine.

[mythria, 2017-03-13 16:47:23]

Description was changed from

==========
Removes ignition specific benchmarks.

Removes the following benchmarks: 
* speedometer-ignition 
* v8.browse_desktop_ignition 
* v8.browse_mobile_ignition, 
* v8.infiniter_scroll-ignition_tbmv2 
* v8.todoMVC-ignition 

The ignition-staging configuration of v8 used in these benchmarks is no longer
the 
shipping configuration. The corresponding turbo benchmarks are tracking the
future 
shipping configuration of v8.

BUG=chromium:670087
==========

to

==========
Removes ignition specific benchmarks.

Removes the following benchmarks: 
* speedometer-ignition 
* v8.browse_desktop_ignition 
* v8.browse_mobile_ignition, 
* v8.infiniter_scroll-ignition_tbmv2 
* v8.todoMVC-ignition 

The ignition-staging configuration of v8 used in these benchmarks is no longer
the 
shipping configuration. The corresponding turbo benchmarks are tracking the
future 
shipping configuration of v8.

BUG=chromium:670087
This issue was moved to gerrit and landed here:
https://chromium-review.googlesource.com/c/451657/.
==========