Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: tools/perf/benchmarks/v8_helper.py

Issue 2711143002: Removes ignition specific benchmarks. (Closed)
Patch Set: Update benchmark json config. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/v8_browsing.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 _JS_FLAGS_SWITCH = '--js-flags=' 5 _JS_FLAGS_SWITCH = '--js-flags='
6 6
7 7
8 def EnableIgnition(options):
9 AppendJSFlags(options, '--ignition-staging')
10
11
12 def EnableTurbo(options): 8 def EnableTurbo(options):
13 AppendJSFlags(options, '--ignition-staging') 9 AppendJSFlags(options, '--ignition-staging')
14 AppendJSFlags(options, '--turbo') 10 AppendJSFlags(options, '--turbo')
rmcilroy 2017/02/23 15:37:49 While you are here could you switch this to --futu
15 11
16 12
17 def AppendJSFlags(options, js_flags): 13 def AppendJSFlags(options, js_flags):
18 existing_js_flags = '' 14 existing_js_flags = ''
19 # There should be only one occurence of --js-flags in the browser flags. When 15 # There should be only one occurence of --js-flags in the browser flags. When
20 # there are multiple flags, only one of them would be used. Append any 16 # there are multiple flags, only one of them would be used. Append any
21 # additional js_flags to the existing flags (if present). 17 # additional js_flags to the existing flags (if present).
22 for extra_arg in options.extra_browser_args: 18 for extra_arg in options.extra_browser_args:
23 if extra_arg.startswith(_JS_FLAGS_SWITCH): 19 if extra_arg.startswith(_JS_FLAGS_SWITCH):
24 # Find and remove the set of existing js_flags. 20 # Find and remove the set of existing js_flags.
25 existing_js_flags = extra_arg[len(_JS_FLAGS_SWITCH):] 21 existing_js_flags = extra_arg[len(_JS_FLAGS_SWITCH):]
26 options.extra_browser_args.remove(extra_arg) 22 options.extra_browser_args.remove(extra_arg)
27 break 23 break
28 24
29 options.AppendExtraBrowserArgs([ 25 options.AppendExtraBrowserArgs([
30 # Add a new --js-flags which includes previous flags. 26 # Add a new --js-flags which includes previous flags.
31 '%s%s %s' % (_JS_FLAGS_SWITCH, js_flags, existing_js_flags) 27 '%s%s %s' % (_JS_FLAGS_SWITCH, js_flags, existing_js_flags)
32 ]) 28 ])
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/v8_browsing.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698