Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2711123004: Cherry-picked remaining parts of 'Fixed title updating for back forward navigation.' (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Cherry-picked remaining parts of 'Fixed title updating for back forward navigation.' Cherry-picked patchset #1 and #2 from cl/2691693002 BUG=688047, 677356 Review-Url: https://codereview.chromium.org/2685803002 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2711123004 Cr-Commit-Position: refs/branch-heads/2987@{#666} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/77569373deed80a50d4787cd594f40953d1596a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 7 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Eugene But (OOO till 7-30)
Cherry-picking remaining parts of https://codereview.chromium.org/2691693002/ to M57. Initially I cherry picked wrong CL, which was ...
3 years, 10 months ago (2017-02-23 17:39:19 UTC) #2
kkhorimoto
lgtm
3 years, 10 months ago (2017-02-23 19:02:30 UTC) #3
Eugene But (OOO till 7-30)
Thank you for quick review!
3 years, 10 months ago (2017-02-23 19:03:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711123004/1
3 years, 10 months ago (2017-02-23 19:04:35 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-23 19:04:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711123004/1
3 years, 10 months ago (2017-02-23 19:48:47 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 19:55:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77569373deed80a50d4787cd594f...

Powered by Google App Engine
This is Rietveld 408576698