Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2711123002: [modules] When debug-printing a module, print its origin if possible. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] When debug-printing a module, print its origin if possible. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2711123002 Cr-Commit-Position: refs/heads/master@{#43392} Committed: https://chromium.googlesource.com/v8/v8/+/32f60470d527116be7411756c02e4709eeae410f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/objects-printer.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
neis
ptal
3 years, 10 months ago (2017-02-23 14:02:08 UTC) #4
adamk
lgtm
3 years, 10 months ago (2017-02-23 17:08:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711123002/1
3 years, 10 months ago (2017-02-23 17:08:40 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:10:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/32f60470d527116be7411756c02e4709eea...

Powered by Google App Engine
This is Rietveld 408576698