Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Issue 2711113004: Stop SpellChecker from adding marker when checking range is modified (Closed)

Created:
3 years, 10 months ago by Xiaocheng
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop SpellChecker from adding marker when checking range is modified This patch makes SpellChecker not to add spelling markers if the checking range has been modified. It also modifies layout test editing/spelling/spellcheck-async-mutation.html, which is supposed to test behavior in such case but was incorrectly designed. BUG=693795 TEST=editing/spelling/spellcheck-async-mutation.html Review-Url: https://codereview.chromium.org/2711113004 Cr-Commit-Position: refs/heads/master@{#452719} Committed: https://chromium.googlesource.com/chromium/src/+/e7f1cb881be7f52498d58b21ea855a5db487a515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -256 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-mutation.html View 1 chunk +113 lines, -209 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-mutation-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Xiaocheng
PTAL.
3 years, 10 months ago (2017-02-24 01:43:14 UTC) #7
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-24 02:15:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711113004/1
3 years, 10 months ago (2017-02-24 02:16:16 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 02:24:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7f1cb881be7f52498d58b21ea85...

Powered by Google App Engine
This is Rietveld 408576698