Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2711073002: WPT tests of allow-top-navigation-by-user-activation for iframe@sandbox. (Closed)

Created:
3 years, 10 months ago by Bin Lu
Modified:
3 years, 10 months ago
Reviewers:
domenic, Rick Byers, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, eae+blinkwatch, jam, kinuko+watch, mlamouri+watch-blink_chromium.org, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WPT tests for allow-top-navigation-by-user-activation for iframe@sandbox. Move the test files for disallowing top navigation given no gesture to WPT, and also adding a manual test for allowing top navigation with user gesture. BUG=662506 Review-Url: https://codereview.chromium.org/2711073002 Cr-Commit-Position: refs/heads/master@{#452609} Committed: https://chromium.googlesource.com/chromium/src/+/290032568531b964b232611699a358900bdb789f

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add an async_test for the manual test to test the top-navigation blocking given no user gesture. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -137 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json View 1 37 chunks +255 lines, -100 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation-manual.html View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture.html View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-iframe-element/support/iframe-that-performs-top-navigation.html View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-iframe-element/support/iframe-that-performs-top-navigation-without-user-gesture-failed.html View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-iframe-element/support/navigation-changed-iframe.html View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/iframe-that-performs-top-navigation-without-user-gesture-failed.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html View 1 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Bin Lu
Does this look good? Thanks.
3 years, 10 months ago (2017-02-23 06:40:19 UTC) #5
domenic
lgtm!
3 years, 10 months ago (2017-02-23 19:01:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711073002/40001
3 years, 10 months ago (2017-02-23 20:01:32 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-23 20:01:34 UTC) #12
Rick Byers
On 2017/02/23 20:01:34, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-23 20:25:31 UTC) #13
Rick Byers
On 2017/02/23 20:25:31, Rick Byers wrote: > On 2017/02/23 20:01:34, commit-bot: I haz the power ...
3 years, 10 months ago (2017-02-23 20:26:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711073002/40001
3 years, 10 months ago (2017-02-23 20:26:42 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 20:36:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/290032568531b964b232611699a3...

Powered by Google App Engine
This is Rietveld 408576698