Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2711063002: Early exit from the search geolocation disclosure if it is disabled. (Closed)

Created:
3 years, 10 months ago by benwells
Modified:
3 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early exit from the search geolocation disclosure if it is disabled. There is no need to perform all the checks for showing the disclosure if the new search geolocation consistency feature is disabled. BUG=681663 Review-Url: https://codereview.chromium.org/2711063002 Cr-Commit-Position: refs/heads/master@{#452415} Committed: https://chromium.googlesource.com/chromium/src/+/f714d2c9fc6f4d8309833d3329fc58b8bba4832a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
benwells
(Hopefully) easy one...
3 years, 10 months ago (2017-02-23 05:49:52 UTC) #6
raymes
lgtm
3 years, 10 months ago (2017-02-23 05:59:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711063002/1
3 years, 10 months ago (2017-02-23 06:04:36 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 06:11:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f714d2c9fc6f4d8309833d3329fc...

Powered by Google App Engine
This is Rietveld 408576698