Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 2711053005: Deflake ConnectionTest.Audio test (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov
Modified:
3 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake ConnectionTest.Audio test WebRTC now ignores x-google-min-bitrate parameter for opus codec, which was used in remoting. As result the audio was sent at 64kbps, instead of desired 160kbps. Updated webrtc_transport to use maxaveragebitrate to specify target bitrate, which should make the test non-flaky. BUG=695384 Review-Url: https://codereview.chromium.org/2711053005 Cr-Commit-Position: refs/heads/master@{#453295} Committed: https://chromium.googlesource.com/chromium/src/+/6aaea61066c6df8a2bceead07fa433ae08ce365c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M remoting/protocol/connection_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Sergey Ulanov
3 years, 9 months ago (2017-02-24 23:17:38 UTC) #2
Jamie
lgtm
3 years, 9 months ago (2017-02-24 23:49:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711053005/1
3 years, 9 months ago (2017-02-27 19:00:09 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:30:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6aaea61066c6df8a2bceead07fa4...

Powered by Google App Engine
This is Rietveld 408576698