Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2711033004: Explicitly invalidate LayoutView when overflow is recalculated. (Closed)

Created:
3 years, 10 months ago by bokan
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Explicitly invalidate LayoutView when overflow is recalculated. This bug occurs because during an animation we may change the amount of layout overflow (via FrameView::recalcOverflowAfterStyleChange). Previously, this would cause a change in scrollbar existance until r432965 made it so that the FrameView would prevent scrollbar creation earlier in cases where they're known to be unneeded. Changing scrollbar existence causes a layout so we'd implicitly invalidate and repaint. Since that change, we (correctly) don't bother doing a layout but because of that we no longer invalidate so the additionally exposed background region doesn't get painted. BUG=683814 Review-Url: https://codereview.chromium.org/2685883004 Cr-Commit-Position: refs/heads/master@{#452170} (cherry picked from commit 717789e00f9ff34efe3a2ca23ebd69e802d8b6ec)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
bokan
3 years, 9 months ago (2017-03-14 21:07:19 UTC) #1
Description was changed from

==========
Explicitly invalidate LayoutView when overflow is recalculated.

This bug occurs because during an animation we may change the amount of layout
overflow (via FrameView::recalcOverflowAfterStyleChange). Previously, this
would cause a change in scrollbar existance until r432965 made it so that the
FrameView would prevent scrollbar creation earlier in cases where they're known
to be unneeded. Changing scrollbar existence causes a layout so we'd implicitly
invalidate and repaint. Since that change, we (correctly) don't bother doing a
layout but because of that we no longer invalidate so the additionally exposed
background region doesn't get painted.

BUG=683814

Review-Url: https://codereview.chromium.org/2685883004
Cr-Commit-Position: refs/heads/master@{#452170}
(cherry picked from commit 717789e00f9ff34efe3a2ca23ebd69e802d8b6ec)
==========

to

==========
Explicitly invalidate LayoutView when overflow is recalculated.

This bug occurs because during an animation we may change the amount of layout
overflow (via FrameView::recalcOverflowAfterStyleChange). Previously, this
would cause a change in scrollbar existance until r432965 made it so that the
FrameView would prevent scrollbar creation earlier in cases where they're known
to be unneeded. Changing scrollbar existence causes a layout so we'd implicitly
invalidate and repaint. Since that change, we (correctly) don't bother doing a
layout but because of that we no longer invalidate so the additionally exposed
background region doesn't get painted.

BUG=683814

Review-Url: https://codereview.chromium.org/2685883004
Cr-Commit-Position: refs/heads/master@{#452170}
(cherry picked from commit 717789e00f9ff34efe3a2ca23ebd69e802d8b6ec)
==========

Powered by Google App Engine
This is Rietveld 408576698