Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2711033004: Explicitly invalidate LayoutView when overflow is recalculated. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 scrollingCoordinator->notifyOverflowUpdated(); 812 scrollingCoordinator->notifyOverflowUpdated();
813 813
814 IntRect documentRect = layoutViewItem.documentRect(); 814 IntRect documentRect = layoutViewItem.documentRect();
815 if (scrollOrigin() == -documentRect.location() && 815 if (scrollOrigin() == -documentRect.location() &&
816 contentsSize() == documentRect.size()) 816 contentsSize() == documentRect.size())
817 return; 817 return;
818 818
819 if (needsLayout()) 819 if (needsLayout())
820 return; 820 return;
821 821
822 // If the visualViewport supplies scrollbars, we won't get a paint
823 // invalidation from computeScrollbarExistence so we need to force one
824 // TODO(bokan): We should avoid computeScrollbarExistence otherwise.
825 if (visualViewportSuppliesScrollbars())
826 layoutViewItem.setMayNeedPaintInvalidation();
827
822 // TODO(pdr): This should be refactored to just block scrollbar updates as 828 // TODO(pdr): This should be refactored to just block scrollbar updates as
823 // we are not in a scrollbar update here and m_inUpdateScrollbars has other 829 // we are not in a scrollbar update here and m_inUpdateScrollbars has other
824 // side effects. This scope is only for preventing a synchronous layout from 830 // side effects. This scope is only for preventing a synchronous layout from
825 // scroll origin changes which would not be allowed during style recalc. 831 // scroll origin changes which would not be allowed during style recalc.
826 InUpdateScrollbarsScope inUpdateScrollbarsScope(this); 832 InUpdateScrollbarsScope inUpdateScrollbarsScope(this);
827 833
828 bool shouldHaveHorizontalScrollbar = false; 834 bool shouldHaveHorizontalScrollbar = false;
829 bool shouldHaveVerticalScrollbar = false; 835 bool shouldHaveVerticalScrollbar = false;
830 computeScrollbarExistence(shouldHaveHorizontalScrollbar, 836 computeScrollbarExistence(shouldHaveHorizontalScrollbar,
831 shouldHaveVerticalScrollbar, documentRect.size()); 837 shouldHaveVerticalScrollbar, documentRect.size());
(...skipping 4219 matching lines...) Expand 10 before | Expand all | Expand 10 after
5051 std::unique_ptr<CompositorAnimationTimeline> timeline) { 5057 std::unique_ptr<CompositorAnimationTimeline> timeline) {
5052 m_animationTimeline = std::move(timeline); 5058 m_animationTimeline = std::move(timeline);
5053 } 5059 }
5054 5060
5055 void FrameView::setAnimationHost( 5061 void FrameView::setAnimationHost(
5056 std::unique_ptr<CompositorAnimationHost> host) { 5062 std::unique_ptr<CompositorAnimationHost> host) {
5057 m_animationHost = std::move(host); 5063 m_animationHost = std::move(host);
5058 } 5064 }
5059 5065
5060 } // namespace blink 5066 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698