Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2711013002: Mark http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html as faili… (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
Nate Chapin, alexmos
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html as failing in --site-per-process mode. With the framebusting intervention disabled, this seems to emit a console message... but only in --site-per-process mode. BUG=661725 Review-Url: https://codereview.chromium.org/2711013002 Cr-Commit-Position: refs/heads/master@{#452261} Committed: https://chromium.googlesource.com/chromium/src/+/730a585cf681f768e75ff5fcf65de66b3cbb3fe5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dcheng
3 years, 10 months ago (2017-02-22 22:03:38 UTC) #4
alexmos
LGTM, this is basically https://crbug.com/680249 happening again.
3 years, 10 months ago (2017-02-22 22:08:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711013002/1
3 years, 10 months ago (2017-02-22 22:13:35 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 23:16:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/730a585cf681f768e75ff5fcf65d...

Powered by Google App Engine
This is Rietveld 408576698