Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2711003007: [ast] Allow dereferencing handles in Print helper. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 9 months ago
Reviewers:
adamk, rmcilroy
CC:
v8-reviews_googlegroups.com, mythria, Leszek Swirski
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Allow dereferencing handles in Print helper. Calling AstNode::Print() from within gdb, e.g. during bytecode generation, sometimes results in a CHECK failure due to handle dereferencing being disallowed. This is very frustrating. Since this function is purely for debugging and not called anywhere in the code base, I'm now explicitly adding an AllowHandleDereference scope to it. R=adamk@chromium.org BUG= Review-Url: https://codereview.chromium.org/2711003007 Cr-Commit-Position: refs/heads/master@{#43439} Committed: https://chromium.googlesource.com/v8/v8/+/2c7508f118c91eed6cd51d141638bbdde9a87aec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ast/ast.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
3 years, 10 months ago (2017-02-24 15:08:56 UTC) #1
adamk
lgtm, ccing ignition folks FYI
3 years, 10 months ago (2017-02-24 17:40:44 UTC) #2
rmcilroy
On 2017/02/24 17:40:44, adamk wrote: > lgtm, ccing ignition folks FYI Lgtm
3 years, 10 months ago (2017-02-24 17:55:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711003007/1
3 years, 9 months ago (2017-02-27 08:55:42 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 09:18:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2c7508f118c91eed6cd51d141638bbdde9a...

Powered by Google App Engine
This is Rietveld 408576698