Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2710983004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=anthonyvd@chromium.org Review-Url: https://codereview.chromium.org/2710983004 Cr-Commit-Position: refs/heads/master@{#452888} Committed: https://chromium.googlesource.com/chromium/src/+/acdf05da7259cb99b6bf779517afb4ccce5e619b

Patch Set 1 #

Total comments: 8

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/profiles/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/profile_metrics/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state_metrics/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-02-23 21:28:30 UTC) #1
anthonyvd
https://codereview.chromium.org/2710983004/diff/1/chrome/browser/ui/views/payments/OWNERS File chrome/browser/ui/views/payments/OWNERS (right): https://codereview.chromium.org/2710983004/diff/1/chrome/browser/ui/views/payments/OWNERS#newcode4 chrome/browser/ui/views/payments/OWNERS:4: # COMPONENT: Blink>Payments Should be UI>Browser>Autofill>Payments https://codereview.chromium.org/2710983004/diff/1/chrome/browser/ui/webui/signin/OWNERS File chrome/browser/ui/webui/signin/OWNERS ...
3 years, 9 months ago (2017-02-24 16:49:48 UTC) #2
ymzhang1
https://codereview.chromium.org/2710983004/diff/1/chrome/browser/ui/views/payments/OWNERS File chrome/browser/ui/views/payments/OWNERS (right): https://codereview.chromium.org/2710983004/diff/1/chrome/browser/ui/views/payments/OWNERS#newcode4 chrome/browser/ui/views/payments/OWNERS:4: # COMPONENT: Blink>Payments On 2017/02/24 16:49:48, anthonyvd wrote: > ...
3 years, 9 months ago (2017-02-24 18:22:46 UTC) #3
anthonyvd
lgtm
3 years, 9 months ago (2017-02-24 18:33:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710983004/20001
3 years, 9 months ago (2017-02-24 18:46:54 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 18:59:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/acdf05da7259cb99b6bf779517af...

Powered by Google App Engine
This is Rietveld 408576698