Record RTT prediction accuracy when using average algorithms

Record RTT prediction accuracy when using average algorithms

In Network Quality Estimator (NQE), record the accuracy of HTTP RTT 
prediction when using weighted average and unweighted average algorithms.
Also, record the HTTP RTT computed using weighted average algorithm.

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2710973003
Cr-Commit-Position: refs/heads/master@{#453480}
Committed: https://chromium.googlesource.com/chromium/src/+/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07

[tbansal1, 2017-02-22 22:06:02]

Description was changed from

==========
Record RTT prediction accuracy when using weighted average algorithm

BUG=
==========

to

==========
Record RTT prediction accuracy when using weighted average algorithm

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-22 22:16:16]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-02-22 22:17:03]

Description was changed from

==========
Record RTT prediction accuracy when using weighted average algorithm

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Record RTT prediction accuracy when using weighted average algorithm

In Network Quality Estimator (NQE), record the accuracy of HTTP RTT 
prediction when using weighted average algorithm. Also, record the HTTP 
RTT computed using weighted average algorithm.

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-22 22:17:19]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-02-22 22:17:19]

ryansturm: ptal. Thanks.

[RyanSturm, 2017-02-24 19:54:18]

lgtm % 

I hate for loop/switch combos. They probably help for compile time warnings, but
it just looks so stupid to have all the code there. You could just have a for
loop that has all the cases, and then entirely separately have all the code you
would put in those cases in a row.

You don't need to fix it, but I think it would be better if there was a better
way to enforce it than using this pattern repeatedly.

https://codereview.chromium.org/2710973003/diff/20001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2710973003/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:540: switch (statistic) {
nit: can you get rid of this switch statement if you just add a statistic to
string method that returns "NQE.WeightedAverage.Accuracy.HttpRTT" for average?

https://codereview.chromium.org/2710973003/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:1064: for (int i = 0; i < STATISTIC_LAST;
++i) {
nit: this for loop/switch is so awkward.

I assume its for compile time assertions, but I don't like it.

[tbansal1, 2017-02-25 03:03:39]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 03:03:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-02-25 03:04:01]

tbansal@chromium.org changed reviewers:
+ rkaplow@chromium.org

[tbansal1, 2017-02-25 03:04:02]

rkaplow: ptal at histograms.xml. Thanks.

https://codereview.chromium.org/2710973003/diff/20001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/2710973003/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:540: switch (statistic) {
On 2017/02/24 19:54:18, Ryan Sturm wrote:
> nit: can you get rid of this switch statement if you just add a statistic to
> string method that returns "NQE.WeightedAverage.Accuracy.HttpRTT" for average?

Done.

https://codereview.chromium.org/2710973003/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:1064: for (int i = 0; i < STATISTIC_LAST;
++i) {
On 2017/02/24 19:54:18, Ryan Sturm wrote:
> nit: this for loop/switch is so awkward.
> 
> I assume its for compile time assertions, but I don't like it.

Done.

[commit-bot: I haz the power, 2017-02-25 04:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 04:09:14]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-02-25 08:04:09]

Patchset #3 (id:60001) has been deleted

[tbansal1, 2017-02-25 08:04:16]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 08:04:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 09:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 09:06:22]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-02-25 20:50:00]

Description was changed from

==========
Record RTT prediction accuracy when using weighted average algorithm

In Network Quality Estimator (NQE), record the accuracy of HTTP RTT 
prediction when using weighted average algorithm. Also, record the HTTP 
RTT computed using weighted average algorithm.

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Record RTT prediction accuracy when using average algorithms

In Network Quality Estimator (NQE), record the accuracy of HTTP RTT 
prediction when using weighted average and unweighted average algorithms.
Also, record the HTTP RTT computed using weighted average algorithm.

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-27 18:23:49]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 18:24:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 19:40:41]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-02-28 02:56:26]

lgtm

[tbansal1, 2017-02-28 02:58:06]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-02-28 02:58:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2710973003/#ps80001
(title: "Add unweighted average")

[commit-bot: I haz the power, 2017-02-28 02:58:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 03:03:44]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488250686100700,
"parent_rev": "974b02737a66b77b9f58889226c5fd6f71539dce", "commit_rev":
"0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07"}

[commit-bot: I haz the power, 2017-02-28 03:04:19]

Description was changed from

==========
Record RTT prediction accuracy when using average algorithms

In Network Quality Estimator (NQE), record the accuracy of HTTP RTT 
prediction when using weighted average and unweighted average algorithms.
Also, record the HTTP RTT computed using weighted average algorithm.

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Record RTT prediction accuracy when using average algorithms

In Network Quality Estimator (NQE), record the accuracy of HTTP RTT 
prediction when using weighted average and unweighted average algorithms.
Also, record the HTTP RTT computed using weighted average algorithm.

BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2710973003
Cr-Commit-Position: refs/heads/master@{#453480}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b44f01eabbb3d90eb98b37f4bff...
==========

[commit-bot: I haz the power, 2017-02-28 03:04:20]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0b44f01eabbb3d90eb98b37f4bff...