Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2710963004: Derive DeviceSettingsTestHelper from MockSessionManagerClient (Closed)

Created:
3 years, 10 months ago by Yusuke Sato
Modified:
3 years, 10 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Derive DeviceSettingsTestHelper from MockSessionManagerClient to reduce total lines of the boilerplate code. BUG=b:32308760 TEST=try Review-Url: https://codereview.chromium.org/2710963004 Cr-Commit-Position: refs/heads/master@{#452676} Committed: https://chromium.googlesource.com/chromium/src/+/7c595a331df7255c4b267bd1af9d2671ced7523b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -138 lines) Patch
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 3 chunks +2 lines, -46 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 3 chunks +0 lines, -92 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Yusuke Sato
Hi, I'm adding a method to the SessionManagerClient class, and wanted to reduce the number ...
3 years, 10 months ago (2017-02-23 23:33:19 UTC) #7
Daniel Erat
lgtm nice, thanks!
3 years, 10 months ago (2017-02-23 23:37:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710963004/1
3 years, 10 months ago (2017-02-23 23:40:02 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 23:46:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c595a331df7255c4b267bd1af9d...

Powered by Google App Engine
This is Rietveld 408576698