Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2710923002: Rename UIActivityFindLoginActionSource to UIActivityURLSource. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 10 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename UIActivityFindLoginActionSource to UIActivityURLSource. BUG=685225 Review-Url: https://codereview.chromium.org/2710923002 Cr-Commit-Position: refs/heads/master@{#451969} Committed: https://chromium.googlesource.com/chromium/src/+/5f64972b263657c4f1b524f1ee544e571758b9dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M ios/chrome/browser/ui/activity_services/activity_service_controller.mm View 1 chunk +7 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/chrome_activity_item_source.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jif
ptal
3 years, 10 months ago (2017-02-22 09:46:45 UTC) #4
Olivier
lgtm
3 years, 10 months ago (2017-02-22 09:52:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710923002/1
3 years, 10 months ago (2017-02-22 09:53:31 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:12:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f64972b263657c4f1b524f1ee54...

Powered by Google App Engine
This is Rietveld 408576698