Removed -[CRWWebDelegate webController:titleDidChange:].

Removed -[CRWWebDelegate webController:titleDidChange:].

Replaced with WebStateObserver::TitleWasSet callback which mirrors
content API.

BUG=674991
Review-Url: https://codereview.chromium.org/2710913006
Cr-Commit-Position: refs/heads/master@{#453473}
Committed: https://chromium.googlesource.com/chromium/src/+/4d5a0d2b7b8076634bbb9efd7f3da647ca04867f

[Eugene But (OOO till 7-30), 2017-02-24 23:49:49]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 23:50:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-02-24 23:53:52]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 23:54:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:23:05]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2017-02-25 01:14:37]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2017-02-25 01:14:47]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-02-25 01:14:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 01:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 01:51:28]

Dry run: This issue passed the CQ dry run.

[kkhorimoto, 2017-02-28 01:14:56]

lgtm, except for style nits.  

Nice to see these CRWWebDelegate functions going away! :)

https://codereview.chromium.org/2710913006/diff/40001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab.mm (right):

https://codereview.chromium.org/2710913006/diff/40001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab.mm:1815: -
(void)webStateDidChangeTitle:(web::WebState*)webState {
Let's move this function next to the other WSO callbacks and keep the ordering
consistent with their ordering in web_state_observer.h

https://codereview.chromium.org/2710913006/diff/40001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2710913006/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:1022: if ([self.nativeController
respondsToSelector:@selector(setDelegate:)]) {
NIT: we can remove curly braces now if you want, since it's a single line.

https://codereview.chromium.org/2710913006/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:1799: if (title) {
NIT: curly braces not necessary here and below

[Eugene But (OOO till 7-30), 2017-02-28 01:26:45]

Thanks!

https://codereview.chromium.org/2710913006/diff/40001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab.mm (right):

https://codereview.chromium.org/2710913006/diff/40001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab.mm:1815: -
(void)webStateDidChangeTitle:(web::WebState*)webState {
On 2017/02/28 01:14:55, kkhorimoto_ wrote:
> Let's move this function next to the other WSO callbacks and keep the ordering
> consistent with their ordering in web_state_observer.h

Done.

https://codereview.chromium.org/2710913006/diff/40001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2710913006/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:1022: if ([self.nativeController
respondsToSelector:@selector(setDelegate:)]) {
On 2017/02/28 01:14:55, kkhorimoto_ wrote:
> NIT: we can remove curly braces now if you want, since it's a single line.
Sure. Either way is fine with me.

https://codereview.chromium.org/2710913006/diff/40001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:1799: if (title) {
On 2017/02/28 01:14:55, kkhorimoto_ wrote:
> NIT: curly braces not necessary here and below
Style Guide is neutral on this issue and I choose to have braces here to be
consistent with the code above (one that has |if (loadSuccess)|). In case of |if
(loadSuccess) {| check I actually like to have braces.

[Eugene But (OOO till 7-30), 2017-02-28 01:26:49]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-02-28 01:26:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2710913006/#ps60001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2017-02-28 01:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:31:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:31:41]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2017-02-28 02:00:19]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-02-28 02:00:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2710913006/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2017-02-28 02:00:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 02:38:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488247219265870,
"parent_rev": "b6d636ad5973cf4ac21ffe5a8e7e1e1a25d9949b", "commit_rev":
"4d5a0d2b7b8076634bbb9efd7f3da647ca04867f"}

[commit-bot: I haz the power, 2017-02-28 02:39:12]

Description was changed from

==========
Removed -[CRWWebDelegate webController:titleDidChange:].

Replaced with WebStateObserver::TitleWasSet callback which mirrors
content API.

BUG=674991
==========

to

==========
Removed -[CRWWebDelegate webController:titleDidChange:].

Replaced with WebStateObserver::TitleWasSet callback which mirrors
content API.

BUG=674991

Review-Url: https://codereview.chromium.org/2710913006
Cr-Commit-Position: refs/heads/master@{#453473}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d5a0d2b7b8076634bbb9efd7f3d...
==========

[commit-bot: I haz the power, 2017-02-28 02:39:13]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4d5a0d2b7b8076634bbb9efd7f3d...