Use factory methods for Skia effects in unit tests.

Use factory methods for Skia effects in unit tests.

To avoid stack allocation of Skia effects we made their constructors non-public
and provide factory methods instead. This patch updates the remaining uses of
the constructors in Chrome.

BUG=skia:2187
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269653

[Dominik Grewe, 2014-05-09 10:35:17]

PTAL.

enne: cc/*
piman: content/*

Thanks.

[piman, 2014-05-09 16:59:17]

LGTM. Are the refcount semantics identical?

[Dominik Grewe, 2014-05-09 17:01:23]

On 2014/05/09 16:59:17, piman wrote:
> LGTM. Are the refcount semantics identical?

Yes. The create() methods just wrap "new SkFoo", so nothing changes for
ref-counting.

[enne (OOO), 2014-05-09 19:03:05]

lgtm2

[Dominik Grewe, 2014-05-09 21:09:25]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-05-09 21:13:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dominikg@chromium.org/271073002/20001

[commit-bot: I haz the power, 2014-05-11 00:37:13]

Change committed as 269653