Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: cc/output/filter_operations_unittest.cc

Issue 271073002: Use factory methods for Skia effects in unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/filter_operations_unittest.cc
diff --git a/cc/output/filter_operations_unittest.cc b/cc/output/filter_operations_unittest.cc
index 329601fd7260aabc89f5b693203ce5071d09bb11..e97379cbd2a6c38b53cb97bb7802997ffd700833 100644
--- a/cc/output/filter_operations_unittest.cc
+++ b/cc/output/filter_operations_unittest.cc
@@ -505,10 +505,10 @@ TEST(FilterOperationsTest, BlendSaturatingBrightnessWithNull) {
}
TEST(FilterOperationsTest, BlendReferenceFilters) {
- skia::RefPtr<SkImageFilter> from_filter = skia::AdoptRef(
- new SkBlurImageFilter(1.f, 1.f));
- skia::RefPtr<SkImageFilter> to_filter = skia::AdoptRef(
- new SkBlurImageFilter(2.f, 2.f));
+ skia::RefPtr<SkImageFilter> from_filter =
+ skia::AdoptRef(SkBlurImageFilter::Create(1.f, 1.f));
+ skia::RefPtr<SkImageFilter> to_filter =
+ skia::AdoptRef(SkBlurImageFilter::Create(2.f, 2.f));
FilterOperation from = FilterOperation::CreateReferenceFilter(from_filter);
FilterOperation to = FilterOperation::CreateReferenceFilter(to_filter);
@@ -526,8 +526,8 @@ TEST(FilterOperationsTest, BlendReferenceFilters) {
}
TEST(FilterOperationsTest, BlendReferenceWithNull) {
- skia::RefPtr<SkImageFilter> image_filter = skia::AdoptRef(
- new SkBlurImageFilter(1.f, 1.f));
+ skia::RefPtr<SkImageFilter> image_filter =
+ skia::AdoptRef(SkBlurImageFilter::Create(1.f, 1.f));
FilterOperation filter = FilterOperation::CreateReferenceFilter(image_filter);
FilterOperation null_filter =
FilterOperation::CreateReferenceFilter(skia::RefPtr<SkImageFilter>());
« no previous file with comments | « no previous file | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698