Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2710713004: Revert "Use the Windows MDM API to check if the machine is being managed." (Closed)

Created:
3 years, 10 months ago by fdoray
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vmpstr+watch_chromium.org, grt+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Use the Windows MDM API to check if the machine is being managed." This reverts commit ee0c03ddb4a10c8c9d14244bdefc8034054e846e. Commit causes failures on Google Chrome ChromeOS and Google Chrome Win: ../../components/update_client/utils.cc:171:39: error: 'IsEnterpriseManaged' is a private member of 'update_client::UpdaterState' if (attr.first != UpdaterState::IsEnterpriseManaged) { BUG=690163 TBR=rogerta@chromium.org,sky@chromium.org,asvitkine@chromium.org,grt@chromium.org,avi@chromium.org,waffles@chromium.org,georgesak@chromium.org,pastarmovj@chromium.org Review-Url: https://codereview.chromium.org/2710713004 Cr-Commit-Position: refs/heads/master@{#452068} Committed: https://chromium.googlesource.com/chromium/src/+/e4dd371c464f77b6fbef56d212f7de71e03bf002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -120 lines) Patch
M base/win/win_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M base/win/win_util.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/crash_keys.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/crash_keys.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 4 chunks +6 lines, -16 lines 0 comments Download
M components/update_client/updater_state.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/update_client/updater_state.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M components/update_client/updater_state_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/update_client/updater_state_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/update_client/utils.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_process_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710713004/1
3 years, 10 months ago (2017-02-22 14:54:08 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:00:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4dd371c464f77b6fbef56d212f7...

Powered by Google App Engine
This is Rietveld 408576698