Media Controls: Remove download button for infinite streams

Media Controls: Remove download button for infinite streams

Specifically, removes the download button for media with infinite
duration, since there is no clear end at which to finish the download.

Also adds tests for the download button being hidden for empty URLs and
HLS streams, and fixes the test for the download button being hidden
when hideDownloadUI setting is disabled by making its video non-local.

BUG=691561, 654507, 650738
Review-Url: https://codereview.chromium.org/2710713003
Cr-Commit-Position: refs/heads/master@{#451852}
Committed: https://chromium.googlesource.com/chromium/src/+/b6920f2e6be77a44ee16b052b45b2c4228854ae0

[johnme, 2017-02-21 16:57:59]

Description was changed from

==========
Media Controls: Remove download button for infinite streams

Also adds tests for the download button being hidden for empty URLs and
HLS streams, and fixes the test for the download button being hidden
when hideDownloadUI setting is disabled by making its video non-local.

BUG=691561,654507,650738
==========

to

==========
Media Controls: Remove download button for infinite streams

Specifically, removes the download button for media with infinite
duration, since there is no clear end at which to finish the download.

Also adds tests for the download button being hidden for empty URLs and
HLS streams, and fixes the test for the download button being hidden
when hideDownloadUI setting is disabled by making its video non-local.

BUG=691561,654507,650738
==========

[johnme, 2017-02-21 17:02:30]

johnme@chromium.org changed reviewers:
+ mlamouri@chromium.org

[johnme, 2017-02-21 17:02:39]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 17:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 18:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:50:00]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-02-21 21:35:58]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-02-21 21:35:59]

lgtm

[commit-bot: I haz the power, 2017-02-21 21:37:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:17:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487712958829000, "parent_rev":
"73601885cf6022ea45eae4eb2468ac6d0d7a39d2", "commit_rev":
"b6920f2e6be77a44ee16b052b45b2c4228854ae0"}

[commit-bot: I haz the power, 2017-02-21 22:17:54]

Description was changed from

==========
Media Controls: Remove download button for infinite streams

Specifically, removes the download button for media with infinite
duration, since there is no clear end at which to finish the download.

Also adds tests for the download button being hidden for empty URLs and
HLS streams, and fixes the test for the download button being hidden
when hideDownloadUI setting is disabled by making its video non-local.

BUG=691561,654507,650738
==========

to

==========
Media Controls: Remove download button for infinite streams

Specifically, removes the download button for media with infinite
duration, since there is no clear end at which to finish the download.

Also adds tests for the download button being hidden for empty URLs and
HLS streams, and fixes the test for the download button being hidden
when hideDownloadUI setting is disabled by making its video non-local.

BUG=691561,654507,650738

Review-Url: https://codereview.chromium.org/2710713003
Cr-Commit-Position: refs/heads/master@{#451852}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6920f2e6be77a44ee16b052b45b...
==========

[commit-bot: I haz the power, 2017-02-21 22:17:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6920f2e6be77a44ee16b052b45b...