Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2710713002: Network traffic annotation added to popular_sites_impl. (Closed)

Created:
3 years, 10 months ago by Ramin Halavati
Modified:
3 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, msramek
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to popular_sites_impl. Network traffic annotation is added to network request of ntp_tiles/popular_sites_impl. BUG=656607 Review-Url: https://codereview.chromium.org/2710713002 Cr-Commit-Position: refs/heads/master@{#452021} Committed: https://chromium.googlesource.com/chromium/src/+/db28325f75a0ea04c612f93849861d01997d3aeb

Patch Set 1 #

Total comments: 25

Patch Set 2 : Annotation updated. #

Total comments: 4

Patch Set 3 : Comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M components/ntp_tiles/popular_sites_impl.cc View 1 2 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Ramin Halavati
We are annotating all network requests in Chromium with a new NetworkTrafficAnnotation scheme. This allows ...
3 years, 10 months ago (2017-02-21 14:44:34 UTC) #2
Marc Treib
I added suggested data below. Also +more popular_sites owners FYI. https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc File components/ntp_tiles/popular_sites_impl.cc (right): https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc#newcode311 ...
3 years, 10 months ago (2017-02-22 09:49:37 UTC) #4
sfiera
https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc File components/ntp_tiles/popular_sites_impl.cc (right): https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc#newcode311 components/ntp_tiles/popular_sites_impl.cc:311: net::DefineNetworkTrafficAnnotation("...", R"( On 2017/02/22 09:49:37, Marc Treib wrote: > ...
3 years, 10 months ago (2017-02-22 10:06:12 UTC) #5
Ramin Halavati
Annotation updated, please review. https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc File components/ntp_tiles/popular_sites_impl.cc (right): https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc#newcode311 components/ntp_tiles/popular_sites_impl.cc:311: net::DefineNetworkTrafficAnnotation("...", R"( On 2017/02/22 10:06:12, ...
3 years, 10 months ago (2017-02-22 10:35:09 UTC) #7
battre
lgtm https://codereview.chromium.org/2710713002/diff/20001/components/ntp_tiles/popular_sites_impl.cc File components/ntp_tiles/popular_sites_impl.cc (right): https://codereview.chromium.org/2710713002/diff/20001/components/ntp_tiles/popular_sites_impl.cc#newcode319 components/ntp_tiles/popular_sites_impl.cc:319: "the New Tab Page is filled with suggestions ...
3 years, 10 months ago (2017-02-22 10:44:05 UTC) #8
Marc Treib
LGTM once battre's nits are adressed https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc File components/ntp_tiles/popular_sites_impl.cc (right): https://codereview.chromium.org/2710713002/diff/1/components/ntp_tiles/popular_sites_impl.cc#newcode314 components/ntp_tiles/popular_sites_impl.cc:314: description: "..." On ...
3 years, 10 months ago (2017-02-22 12:16:37 UTC) #9
battre
On 2017/02/22 12:16:37, Marc Treib wrote: > LGTM once battre's nits are adressed > > ...
3 years, 10 months ago (2017-02-22 12:24:20 UTC) #10
Ramin Halavati
Comments addressed, landing. https://codereview.chromium.org/2710713002/diff/20001/components/ntp_tiles/popular_sites_impl.cc File components/ntp_tiles/popular_sites_impl.cc (right): https://codereview.chromium.org/2710713002/diff/20001/components/ntp_tiles/popular_sites_impl.cc#newcode319 components/ntp_tiles/popular_sites_impl.cc:319: "the New Tab Page is filled ...
3 years, 10 months ago (2017-02-22 12:26:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710713002/40001
3 years, 10 months ago (2017-02-22 12:27:14 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 13:10:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/db28325f75a0ea04c612f9384986...

Powered by Google App Engine
This is Rietveld 408576698