Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 2710703006: Remove unused PresentationServiceImpl message code (Closed)

Created:
3 years, 10 months ago by btolsch
Modified:
3 years, 10 months ago
Reviewers:
imcheng, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dglazkov+blink, darin-cc_chromium.org, blink-reviews, darin (slow to review), blink-reviews-api_chromium.org, zhaobin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused PresentationServiceImpl message code Since the move to a separate Mojo interface for presentation connection messages, some code in PresentationServiceImpl relating to messages is now unused. This change removes that dead code. BUG=696019 Review-Url: https://codereview.chromium.org/2710703006 Cr-Commit-Position: refs/heads/master@{#452983} Committed: https://chromium.googlesource.com/chromium/src/+/ff7311159a7f270b38d2e696bf69ac5ee8da45ee

Patch Set 1 #

Patch Set 2 : Remove unused static function #

Patch Set 3 : Remove reference to deleted variable in test #

Patch Set 4 : Remove unused PresentationDispatcher test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -272 lines) Patch
M content/browser/presentation/presentation_service_impl.h View 1 2 3 4 chunks +0 lines, -11 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 3 chunks +0 lines, -84 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 1 2 3 chunks +0 lines, -155 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher_unittest.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/public/platform/modules/presentation/presentation.mojom View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
btolsch
I'm not sure if this was being kept for use later, but it's no longer ...
3 years, 10 months ago (2017-02-23 09:41:37 UTC) #18
dcheng
rs lgtm for mojom deletions
3 years, 10 months ago (2017-02-23 19:03:05 UTC) #19
imcheng
lgtm. Could you please add a bug number? +zhaobin as FYI.
3 years, 10 months ago (2017-02-24 20:34:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710703006/60001
3 years, 10 months ago (2017-02-24 21:25:37 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 23:12:42 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ff7311159a7f270b38d2e696bf69...

Powered by Google App Engine
This is Rietveld 408576698