Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2710703003: Shorten IMMEDIATE_CRASH() code size on win clang (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, Reid Kleckner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shorten IMMEDIATE_CRASH() code size on win clang R=thakis@chromium.org, primiano@chromium.org BUG=664209, 694670 Review-Url: https://codereview.chromium.org/2710703003 Cr-Commit-Position: refs/heads/master@{#451857} Committed: https://chromium.googlesource.com/chromium/src/+/6a23306766d02a480c7992f91b51e9691d6511b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M base/logging.h View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
scottmg
3 years, 10 months ago (2017-02-21 19:01:05 UTC) #1
Nico
lgtm
3 years, 10 months ago (2017-02-21 21:11:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710703003/1
3 years, 10 months ago (2017-02-21 21:18:08 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 23:53:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a23306766d02a480c7992f91b51...

Powered by Google App Engine
This is Rietveld 408576698