Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2710693002: Update compile_platform to not use dartk. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, kustermann
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -110 lines) Patch
M pkg/front_end/lib/src/fasta/compile_platform.dart View 1 chunk +63 lines, -110 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/compile_platform_dartk.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compiler_command_line.dart View 2 chunks +8 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
3 years, 10 months ago (2017-02-21 12:49:24 UTC) #2
Vyacheslav Egorov (Google)
LGTM! With a platform.dill generated via fasta we have: $ tools/test.py -c dartk -m release ...
3 years, 10 months ago (2017-02-21 15:24:49 UTC) #4
ahe
3 years, 10 months ago (2017-02-22 09:04:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
640aae9e523ea41024aaa7b861a69bc46596a9df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698