Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2705263002: Handle redirecting constructors to DillMemberBuilder. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Handle redirecting constructors to synthetic or dill builders. #

Total comments: 1

Patch Set 3 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A pkg/front_end/test/fasta/redirecting_constructor.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/redirecting_constructor.dart.direct.expect View 1 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/redirecting_constructor.dart.outline.expect View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahe
Notice that synthetic constructors (as B's default constructor) are DillMemberBuilders. See SourceClassBuilder.addSyntheticConstructor. https://codereview.chromium.org/2705263002/diff/20001/pkg/front_end/test/fasta/redirecting_constructor.dart.direct.expect File pkg/front_end/test/fasta/redirecting_constructor.dart.direct.expect ...
3 years, 10 months ago (2017-02-22 10:03:30 UTC) #3
karlklose
LGTM
3 years, 10 months ago (2017-02-22 11:08:51 UTC) #4
ahe
3 years, 10 months ago (2017-02-22 11:29:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
585933825e1973628941eb116c252c0b1b303d93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698